Functional tests compatible with PHPUnit 6. #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weitzman
commented
Sep 22, 2018
| @@ -35,6 +35,7 @@ jobs: | |||
| - run: $HOME/drush/.circleci/setup.sh | |||
| - run: composer remove --dev webflo/drupal-core-strict --no-update | |||
| - run: composer require --dev drupal/core:8.7.x-dev --no-update | |||
| - run: composer config platform.php 7.2 | |||
There was a problem hiding this comment.
This brings in PHPUnit 6 during build_highest
weitzman
commented
Sep 22, 2018
| * @return \PHPUnit_Framework_TestResult | ||
| * @throws \PHPUnit_Framework_Exception | ||
| */ | ||
| public function run(\PHPUnit_Framework_TestResult $result = null) |
There was a problem hiding this comment.
This chunk was an OO error on PHPUnit 5. Not sure how to make both 5 and 6 happy with same code. See https://circleci.com/gh/drush-ops/drush/3338
I'm sad to lose this code coverage collecting during $this->drush() calls but we are not using it anyway. If anyone can fix that error we will bring this code back
weitzman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.