Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert browse to an annotated command (master). #2341

Merged
merged 2 commits into from
Sep 12, 2016

Conversation

weitzman
Copy link
Member

@weitzman weitzman commented Sep 11, 2016

Same as #2315 but for master branch. Here are a few limitations that can be pushed to a followup I think:

  1. drush_complete_get() (and various parts of Drush) assume that drush_get)commands() is a full command list. It looks like annotated commands are not there. I found those at $application->all().
  2. No handling for @bootstrap and @handle-remote-commands annotations. Not sure where to implement those in master.

@greg-1-anderson
Copy link
Member

  1. Our original plan was to remove all of the old-style commands on the master branch. We could revisit this, in which case we should call the old command hooks and convert them into Symfony objects. (A lot of adapters would be needed to do that.) In either event, completion will need to be reimplemented.

You are correct that @bootstrap & c. still need to be implemented here. I think we can go ahead and merge this here now anyway, and deal with the other tbds as follow-on tasks.

@weitzman weitzman merged commit b0a27da into master Sep 12, 2016
@weitzman weitzman deleted the annotated-conversion-master branch September 12, 2016 21:41
mikeker pushed a commit to mikeker/drush that referenced this pull request Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants