'Sanitize query failed' with 'sqlsan --sanitize-password=no' on D8 #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveoliver
changed the title
| @@ -619,7 +619,7 @@ function drush_sql_get_version() { | |||
| function sql_drush_sql_sync_sanitize($site) { | |||
| $site_settings = drush_sitealias_get_record($site); | |||
| $databases = sitealias_get_databases_from_record($site_settings); | |||
| $major_version = drush_drupal_major_version($site_settings['root']); | |||
| $major_version = drush_drupal_major_version(); | |||
There was a problem hiding this comment.
I guess site_settings['root'] isn't always helpful.
weitzman
pushed a commit
that referenced
this pull request
Jul 12, 2016
…2251) * Fixed undefined major_version var when password not sanitized for D8.
mikeker
pushed a commit
to mikeker/drush
that referenced
this pull request
Aug 10, 2017
…rush-ops#2251) * Fixed undefined major_version var when password not sanitized for D8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
$major_versionvariable defined within the TRUE check for password sanitization,sqlsan --sanitize-password=noon Drupal 8 is unable to determine the proper user table to UPDATE and the command will fail with[error] Sanitize query failed.This 2-line PR simply moves the
$major_versionvariable to the top of the function so that even when passwords are not sanitized, the correct user table can be determined and the query will succeed.