Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear cache when no database updates, fixes #755 #1802

Merged
merged 1 commit into from
Nov 27, 2015

Conversation

helmo
Copy link
Contributor

@helmo helmo commented Nov 23, 2015

No description provided.

@weitzman
Copy link
Member

updb now has --cache-clear=0 if you want to manually control the cache step. we also have updatedb-status.

neither of those does what this PR does. someone needs to look at this closely. i probably wont do that myself given the available workarounds.

@helmo
Copy link
Contributor Author

helmo commented Nov 24, 2015

Both workarounds are just that ... :(

It just bugs me that caches are cleared when nothing has been done.
If I set --cache-clear=0 then I have to check myself if caches need to be flushed... and with the updatedb-status command I'm adding extra overhead and complexity.

@ergonlogic
Copy link
Member

This looks pretty reasonable to me. It also matches Drupal's behaviour more closely. Drupal doesn't clear caches if there weren't any updates to apply.

weitzman added a commit that referenced this pull request Nov 27, 2015
Don't clear cache when no database updates, fixes #755
@weitzman weitzman merged commit 37824e7 into drush-ops:master Nov 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants