Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Symfony var-dumper component as Boris variable inspector #1102

Closed
wants to merge 3 commits into from

Conversation

damiankloip
Copy link
Contributor

The drush php command currently uses Boris, and the standard ColoredInspector to show variables.

The Symfony var-dumper component has much more going for it. It shows much more information about objects, like property visibility, array counts... The ColoredInspector does not show any protected properties (which is most properties in D8 now) or floats for example. See the screenshots below:

Now:

Array

drush_____sites_d8_core_ php _264x50

Action config entity

drush_____sites_d8_core_ php _264x50

With PR:

Array

_forks_drush_drush_____sites_d8_core php _264x50_and_testing_text_format___hrweb

Action config entity

_forks_drush_drush_____sites_d8_core php _264x50

@dawehner
Copy link
Contributor

Best thing!!!!

@LionsAd
Copy link

LionsAd commented Jan 16, 2015

+1 to this change

@weitzman
Copy link
Member

  1. We use Kint library to do this in devel. It would be nice to standardize on Kint or VarDumper. Kint can do CLI. Has anyone compared them? I'd like to hear more about this before commit.
  2. How are you guys using Boris? I'd love a blog post or a tweet about it. I dont think enough people know about it.

@damiankloip
Copy link
Contributor Author

I tried Kint::dump() at the cli too and from what it looks like (IMO), not as good as VarDumper. It should similar information but in a way less concise way.

Same examples as PR description, but with Kint::dump():

drush_____sites_d8_core_ php _264x50

@LionsAd
Copy link

LionsAd commented Jan 19, 2015

I think VarDumper has the better syntax output, too. Kint is way too verbose for quickly seeing what is relevant.

@dawehner
Copy link
Contributor

IMHO the CLI environment has so many more restrictions, (for example you can't collapse stuff).
Given that, I don't think we need consistency in terms of using the same library.

Yes, it would be nice if both libraries would work more together

@weitzman
Copy link
Member

OK, I'm fine with this PR. Needs reroll as changes were made to composer.lock.

@weitzman weitzman closed this in 052c6df Feb 1, 2015
@wimleers
Copy link
Contributor

AWESOME! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants