Internal calls to query() in sql commands should run even in --simulate ... #1005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
sql-dump --simulate
does not work properly as table selection queries do not run (because we are in simulate mode). That can be fixed in an ugly way by this PR or perhaps we should just use drush_invoke_process() with override-simulated backend option instead. My annoyance with that approach is that you have to decide whether or not to $integrate the log for the backend call. I wish we could integrate only in the case of errors. Because usually, $integrate just adds noise.