Example dis-all drushrc shell alias doesn't work anymore.

[kenorb]

There is the following example.drushrc.php example how to use shell aliases:

# $options['shell-aliases']['dis-all'] = '!drush -y dis `drush pml --status=enabled --type=module --no-core --pipe`';

I've tried exactly the same alias, but it doesn't work:

$ drush -v @remote.dev dis-all
Calling proc_open(ssh drush@foo 'cd /var/www && drush -y dis '\''`drush'\'' pml '\''--status=enabled'\'' '\''--type=module'\'' --no-core '\''--pipe`'\''');
Unknown options: --status, --type, --no-core, --pipe`.  See `drush help pm-disable` for available options.

Is the example wrong and should be updated, or it's some kind of bug?

---

Tested the following simple command substitution, it fails as well:

'test' => '!echo `id`',

by printing just:

`id`

The same with $().

With these examples:

'test-3' => "!echo `id`",
'test-4' => "!echo $(id)",

It's saying:

The drush command 'test-3' could not be found.
The drush command 'test-4' could not be found.

---

Drush Version : 7.0-dev

[weitzman]

This is broken for me as well, even on 6.x and 5.x. Wonder if it ever worked.

[greg-1-anderson]

This was modified here:

https://www.drupal.org/node/1757236

And originally committed here:

commit 53fb5d2
Author: Moshe Weitzman weitzman@tejasa.com
Date: Wed Mar 14 16:02:07 2012 -0400

Issue #1304400 by msonnabaum: Added shell-alias for disabling all modules.

Seems like it should have worked at some point, but I couldn't get it to work, even rolling back to the above commit. It seems that shell aliases execute by using proc_open. proc_open does appear to use a shell to execute the provided command, so $() and related should work; however, Drush shell-escapes the parameters first, so my test of '!echo $(hostname)' said:

Calling proc_open(echo '$(hostname)');
$(hostname)

I could have swore that I tested dis-all at some point in the past, but I can't seem to find a time in Drush's history when it works. :?

The shell-escaping of parameters happens in drush_core_execute(). It explicitly does not escape certain items, such as && and ;. We could pretty easily add additional exceptions here, such as omitting escaping on any parameter that begins with '$'. However, this is insufficient for shell aliases, which split their commands by spaces. So, '!echo $(hostname -f)' would be passed as three arguments, 'echo', '$(hostname' and '-f)'. In order to fix this, we would need to add a more sophisticated parser to split the shell aliases. Right now, we use: $alias_value = str_getcsv($alias_value, ' ');

[greg-1-anderson]

I realized that it is silly to go to a lot of effort to split a string just right, only so that it can be escaped and put back the way it was again. See referenced PR, which adds an option --escape=0 to core-exec, so that shell aliases may send their arguments to the shell unaltered, so that they will be interpreted.

[greg-1-anderson]

Again, it appears that the test errors are limited to 'make' tests unrelated to this change.

[greg-1-anderson]

Merged the PR.