Drush pm-download puts drush commands in wrong location.

[Chi-teck]

I suppose this was introduced by the following commit dd7e013.

A module is a pure drush command if it has no .info.yml and contain .drush.inc files.

This assumption is not correct. Many drush related modules contain info file. I faced this problem when installing Site Audit drush command.
I just checked first 10 projects from this list and found 3 projects that do have info file. That means about 30% projects of that list will be downloaded to a wrong location.

[weitzman]

Site audit looks like a regular Drupal module with drush integration (via a symfony console command). I looked at its 8.3 branch.

[Chi-teck]

That means about 30% projects of that list will be downloaded to a wrong location.

More precisely 35.6 % in the Drupal 7 codebase. I just found them all with the following snippet:

#! /bin/bash

for directory in * ; do
  if [ ! "$(find $directory -name *.module)" ] && [ "$(find $directory -name *.info)" ] && [ "$(find $directory -name *.drush.inc)" ]; then
    url=https://www.drupal.org/project/$directory
    title=$(wget --quiet -O - $url  | sed -n -e 's!.*<h1 id="page-subtitle">\(.*\)</h1>.*!\1!p')
    echo "[$title]($url)"
  fi
done

Output:

1. apachesolr_reindex
2. Configuration Manager
3. Composer Generate
4. Drush dpkg
5. Drush
6. Drush clone
7. Drush Compass
8. Drush Download File
9. Drush extras
10. Drush grant RID
11. drushify
12. Drush Issue Queue Commands
13. Drush IQ Extras
14. Drush Mandrill Statistics
15. Drush Migrate Inspect
16. Drush Modulesmith
17. Drush Permissions
18. Drush Queue
19. Drush Recipes
20. Drush SQL Sync Pipe
21. Drush Symlinks
22. Drush Taxonomyinfo
23. Drush Typeinfo
24. File permissions
25. Git Release Notes for Drush
26. Instaweb
27. Locale Import/Export
28. MAMP
29. Hard-working Monkey
30. PHP Server
31. Privatize
32. Project Status
33. Provision
34. Provision ACL support
35. Provision boost support
36. Provision Cloud Files
37. Provision Git Features
38. Provision hosting injections
39. Drush Refactor Project
40. Rush
41. Drush Search & Replace
42. Sensitive Data
43. Settings.php generator
44. Site Audit
45. Surf
46. Turnip
47. Valkyrie

[weitzman]

I think my intent in that commit was to change behavior for D8+ only. So, we have a bug.

[weitzman]

Thanks @Chi-teck for the link to the ill commit and for the command listing. Hope I got it right this time.