Skip to content

Conversation

@soniktrooth
Copy link
Contributor

This didn't seem to be disastrous when I was looking at it in Chrome but I imagine it could kill and older browser.

@pirog
Copy link
Contributor

pirog commented Mar 4, 2015

im a little out of the loop on this so it would be great to get the thumbs up from either @madeofpeople @RobLoach or @andrewmallis

@andrewmallis
Copy link
Member

inspecting the code, it does look like this is a legit typo.
Have not QA'd it though, so no explicit thumbs up. Rather a one-handed clap ✋

@soniktrooth
Copy link
Contributor Author

If I do one too then it can be a high five and that's better than thumbs up ✋

@thiagodemellobueno
Copy link
Contributor

::hand:: ::hand::

@soniktrooth
Copy link
Contributor Author

This is tested and working over on CITC—can someone merge it? I don't have write access yet.

@soniktrooth soniktrooth force-pushed the 7.x-3.x-missing-comma-local-task branch from 19c1a0a to d2851c9 Compare April 21, 2015 17:26
pirog added a commit that referenced this pull request Apr 22, 2015
…task

Missing comma breaks menu_local_task markup
@pirog pirog merged commit d8e1750 into drupalprojects:7.x-3.x Apr 22, 2015
@pirog
Copy link
Contributor

pirog commented Apr 22, 2015

done

also @soniktrooth i gave you write acess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants