Responsive toggle - this shouldn't be an option for a "mobile first" theme

[bassettsj]

Adding the settings field to add the meta tag is silly, this should just be on. Bootstrap has gotten rid of the "responsive" stylesheet, so we should follow their lead here.

<meta content="width=device-width" name="viewport">

[bassettsj]

@pirog Are you strongly advocating for this option?

[bassettsj]

@carsonblack Do you have an opinion here? I just think it is silly in this day of age to have a non-responsive theme at all...

[carsonblack]

My expectation that this is going to be responsive out of the box and is one of the main reasons why I would even use this in the first place. The settings field seems like cruft.

[bassettsj]

It is gone then in 7.x-4.x 👍

[pirog]

That toggle doesn't change whether the theme is responsive or not. It just
hides the responsive toggling choices in kalacustomize which might be a
nice option.

On Friday, June 20, 2014, Steven Bassett notifications@github.com wrote:

It is gone then in 7.x-4.x [image: 👍]

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

Cheers,

Mike Pirog
Kalamuna
www.kalamuna.com

[bassettsj]

@pirog it also outputs that meta tag ☝️ that tells the browser to make the page match the viewport of the browser.

[pirog]

@bassettsj weird... it should definitely not do that.

hiding the toggling options make sense but the theme should just be responsive, that shouldn't be a choice because duh.

[bassettsj]

Cool so we all agree.

[pirog]

Yes although looking at the code for 3.x it doesnt look like adding or removing this meta content is dependent on the responsive toggle setting at all.

/**
 * Load Kalatheme dependencies.
 *
 * Implements template_preprocess_html().
 */
function kalatheme_preprocess_html(&$variables) {
  // Load all dependencies.
  _kalatheme_load_dependencies();
  // Add variables for path to theme.
  $variables['base_path'] = base_path();
  $variables['path_to_kalatheme'] = dirname(__FILE__);
  // Add meta for Bootstrap Responsive.
  // <meta name="viewport" content="width=device-width, initial-scale=1.0">
  $element = array(
    '#tag' => 'meta',
    '#attributes' => array(
      'name' => 'viewport',
      'content' => 'width=device-width, initial-scale=1.0',
    ),
  );
  drupal_add_html_head($element, 'bootstrap_responsive');
}