Add asset-packagist repository and config. #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! Code looks good. Can we just clarify in the readme that we're talking about JS libraries? It might not be immediately obvious, many refer to PHP packages as libraries as well. |
Contributor
|
Well anything front-end :) not just JS
…On Wed, Oct 25, 2017 at 8:44 AM Bojan Zivanovic ***@***.***> wrote:
Thanks! Code looks good. Can we just clarify in the readme that we're
talking about JS libraries? It might not be immediately obvious, many refer
to PHP packages as libraries as well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADhv1CXRfeE-ZNKBCp0n5DUO7_IGHt10ks5svzsjgaJpZM4QGBY1>
.
|
Contributor
Author
|
Clarified a bit. |
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://www.drupal.org/node/2916058
To test, I cloned this repo, ran composer install, and then
composer require bower-asset/dropzone. Make sure new code is in web/libraries, not vendor/bower-asset