Skip to content

Conversation

AlexSkrypnyk
Copy link
Collaborator

@AlexSkrypnyk AlexSkrypnyk commented May 17, 2024

#278

Changes:

  • Added support for asset packagist.
  • Added oomphinc/composer-installers-extender to support installation of bower-asset and npm-asset type libraries. composer/installers supports only drupal-library type.
  • Added check in CI that the library is installed into the correct location.
  • Added documentation to README.md file.

Once this PR is approved, I will create a similar PR for 11.x

@AlexSkrypnyk AlexSkrypnyk marked this pull request as draft May 17, 2024 01:46
@AlexSkrypnyk AlexSkrypnyk self-assigned this May 17, 2024
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/278-10x-add-asset-packagist branch from 7576ef0 to ace4b81 Compare May 17, 2024 01:49
@AlexSkrypnyk AlexSkrypnyk added the PR: Needs review Pull request needs a review from assigned developers label May 17, 2024
@AlexSkrypnyk AlexSkrypnyk marked this pull request as ready for review May 17, 2024 01:51
@AlexSkrypnyk AlexSkrypnyk requested review from normanlolx and webflo May 17, 2024 01:51
@simesy
Copy link

simesy commented May 17, 2024

It feels like asset packagist isn't universally loved.

Copy link
Collaborator

@normanlolx normanlolx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀 only one minor thing I spotted

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/278-10x-add-asset-packagist branch from ace4b81 to ab222b9 Compare May 17, 2024 06:21
@AlexSkrypnyk AlexSkrypnyk requested a review from normanlolx May 17, 2024 06:21
@AlexSkrypnyk AlexSkrypnyk merged commit 4013e3f into 10.x May 17, 2024
@AlexSkrypnyk AlexSkrypnyk deleted the feature/278-10x-add-asset-packagist branch August 14, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D10 PR: Needs review Pull request needs a review from assigned developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants