Skip to content

Conversation

AlexSkrypnyk
Copy link
Collaborator

@AlexSkrypnyk AlexSkrypnyk commented May 13, 2024

Closes #462

@AlexSkrypnyk AlexSkrypnyk self-assigned this May 13, 2024
@AlexSkrypnyk AlexSkrypnyk requested a review from normanlolx May 13, 2024 10:21
@AlexSkrypnyk AlexSkrypnyk added PR: Needs review Pull request needs a review from assigned developers D11 labels May 13, 2024
Copy link
Collaborator

@normanlolx normanlolx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this looks nice also with that section in the README. 🤩

@normanlolx normanlolx self-requested a review May 14, 2024 08:32
README.md Outdated
"platform": {
"php": "8.3.1"
}
"platform": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexSkrypnyk this is indented differently than in the other MR. Wouldn't it be better we indent it the same way in both?

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/462-11x-remove-php-versions branch from 63867f9 to e233829 Compare May 14, 2024 08:42

```json
"config": {
"sort-packages": true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this line as it has nothing to do with what we are trying to show here

@AlexSkrypnyk AlexSkrypnyk requested a review from normanlolx May 14, 2024 08:43
@AlexSkrypnyk AlexSkrypnyk merged commit 7fab10d into 11.x May 14, 2024
@AlexSkrypnyk AlexSkrypnyk deleted the feature/462-11x-remove-php-versions branch August 14, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D11 PR: Needs review Pull request needs a review from assigned developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants