Check the Composer version before downloading the dependencies #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a doc block with the link to the GitHub issue? Thanks! |
|
Sure! I've added a docblock. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced a problem yesterday during a workshop where people weren't able to scaffold Drupal correctly. This turned out to be caused by doing an initial installation using an outdated version of composer.
We do not have the
composer.lockfile committed (to avoid merge conflicts downstream) and an initial installation without a lock file is now considered to be an update command. This change has been recently introduced in Composer (in composer/composer#5035). If someone is using an older version this means the Drupal scaffolding is not performed.Since this change has been introduced shortly before Composer 1.0.0 I would propose to check for this version.