Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsass doesn't work well together with Sass-Mixins #28

Closed
anselmh opened this issue Jan 2, 2014 · 3 comments
Closed

libsass doesn't work well together with Sass-Mixins #28

anselmh opened this issue Jan 2, 2014 · 3 comments
Assignees
Labels

Comments

@anselmh
Copy link
Contributor

anselmh commented Jan 2, 2014

I’ve encountered a bug that using the x-rem mixin from Sass-Mixins doesn’t work with libsass. The generated output is:

min-height: 15;
min-height: 15;

instead of

min-height: 240px;
min-height: 15rem;

This is a bit of an urgent issue as this affects the Sass-functionality of INIT, too.

@anselmh
Copy link
Contributor Author

anselmh commented Jan 2, 2014

Issue is https://github.com/drublic/Sass-Mixins/blob/master/partials/_rem.scss#L37 if statement which somehow resolves wrong due to the type-of statement.

EDIT

Here's a quick fix which is pretty ugly (line 624 in mixins.scss or l37 in _rem.scss):

@if ( $value == 0 ) or type_of($value) == string or type_of($value) == color or type_of($value) == bool {

@drublic
Copy link
Owner

drublic commented Jan 2, 2014

I'm good with the fix. Can do PR? Thank you.

@anselmh
Copy link
Contributor Author

anselmh commented Jan 2, 2014

Sure thing. Will do later.

anselmh added a commit that referenced this issue Jan 2, 2014
@ghost ghost assigned anselmh and drublic Jan 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants