Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker component creation #155

Merged
merged 24 commits into from
Apr 26, 2024
Merged

DatePicker component creation #155

merged 24 commits into from
Apr 26, 2024

Conversation

Ftarganski
Copy link
Contributor

Description:
DatePicker component creation.

Code changes:

  • feat CU-86dtb1yy1

Breaking change:

  • Yes
  • [] No

Observation:
Some additional information. (Optional)

@github-actions github-actions bot added the feature New Features and cool stuff label Apr 22, 2024
@Ftarganski Ftarganski changed the title Atualizar versão para 3.4.1 DatePicker component creation Apr 23, 2024
@Ftarganski
Copy link
Contributor Author

Ftarganski commented Apr 23, 2024 •
edited
Loading

Sim, está em Draft, mas se puderem já olhar eu agradeço.

Faltam poucos ajustes.

@YaGRRusso @inaciogu @gabrielh-silvestre

YaGRRusso
YaGRRusso reviewed Apr 23, 2024
View reviewed changes
package/src/App.tsx Outdated Show resolved Hide resolved
YaGRRusso
YaGRRusso requested changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@YaGRRusso YaGRRusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nem vou olhar o resto, quando passar a lógica do value pra fora e usar o Popover esse código vai ficar 1/3 do que é agora

@Ftarganski Ftarganski marked this pull request as ready for review April 24, 2024 22:30
@Ftarganski Ftarganski marked this pull request as draft April 25, 2024 13:18
@Ftarganski Ftarganski marked this pull request as ready for review April 25, 2024 16:13
@Ftarganski Ftarganski merged commit 7501503 into main Apr 26, 2024
3 checks passed
@Ftarganski Ftarganski deleted the feat-visu-datepicker branch April 26, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaGRRusso YaGRRusso YaGRRusso approved these changes

@inaciogu inaciogu Awaiting requested review from inaciogu

@gabrielh-silvestre gabrielh-silvestre Awaiting requested review from gabrielh-silvestre

Assignees
No one assigned
Labels
feature New Features and cool stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ftarganski @YaGRRusso