Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust collapsed sidebar component to show Avatar component #133

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Adjust collapsed sidebar component to show Avatar component #133

merged 1 commit into from
Mar 12, 2024

Conversation

Ftarganski
Copy link
Contributor

📝 Description

CU-86drv9t7v

  • Adjust collapsed sidebar component to show Avatar component

🚀 Why is this change required and behavior changes

  • Sidebar component, collapsed, did not show the avatar component internally
  • The problem was in the logic of hiding sidebar children

💣 Is this a breaking change:

  • Yes
  • No

📝 Additional Information

Checklist

  • I've created/modified some component
  • I've created/modified the component's stories
  • I've created/modified the component's tests

@Ftarganski Ftarganski marked this pull request as ready for review March 12, 2024 13:50
@github-actions github-actions bot added the feature New Features and cool stuff label Mar 12, 2024
@Ftarganski Ftarganski merged commit 9608bc2 into main Mar 12, 2024
5 checks passed
@Ftarganski Ftarganski deleted the feat-visu-sidebar branch March 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaGRRusso YaGRRusso YaGRRusso approved these changes

@inaciogu inaciogu Awaiting requested review from inaciogu

@gabrielh-silvestre gabrielh-silvestre Awaiting requested review from gabrielh-silvestre

Assignees
No one assigned
Labels
feature New Features and cool stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ftarganski @YaGRRusso