Skip to content

ExponentiallyDecayingReservoir stops registering updates #793

Description

@sotodel

In ExponentiallyDecayingReservoir, if enough time has passed since you created it (~13+ hours), the weight calculation https://github.com/dropwizard/metrics/blob/master/metrics-core/src/main/java/com/codahale/metrics/ExponentiallyDecayingReservoir.java#L97 returns Double.Infinity, causing priority to be also Double.Infinity, causing collisions in the Map and therefore no new updates (assuming newCount > size).

update calls are therefore almost no-op. They only increment the count.

We originally noticed this in the .NET port https://github.com/danielcrenna/metrics-net/issues/45.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions