convert to GitHub Actions, fix Python 3.5.1 and add newer Pythons#108
Open
terencehonles wants to merge 1 commit intodropbox:masterfrom
Open
convert to GitHub Actions, fix Python 3.5.1 and add newer Pythons#108terencehonles wants to merge 1 commit intodropbox:masterfrom
terencehonles wants to merge 1 commit intodropbox:masterfrom
Conversation
7d3f51a to
df257e3
Compare
|
@terencehonles Please see the comment about Python 3.5.1 in #110 @JukkaL Would it be possible to review and land this PR (or similar) to test on current versions of Python? |
df257e3 to
d3df7f8
Compare
Author
|
@cclauss ack. I dropped Python 3.5.1, @gvanrossum are you suggesting to drop 3.5 too? x-ref: #110 (comment) |
48ee7b3 to
9b214f5
Compare
Author
|
It looks like GitHub Actions would also need to be enabled in this repo/org. You can see the runs in my fork: https://github.com/terencehonles/pyannotate/actions |
9b214f5 to
07e4f62
Compare
Author
|
It looks like typed-ast is broken on Python 3.10 and broke since I opened this PR. I changed Python 3.10 to be an optional check for now: https://github.com/terencehonles/pyannotate/runs/2314171569?check_suite_focus=true#step:5:55 |
Author
|
Looks like that was already fixed but not yet released: python/typed_ast#158 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed getting tests through Travis is taking a long time now. I had also fixed Python 3.5.1 in #107 but it looks like there were more adjustments to the
requirements.txtto not rely on Travis's built in / pre-installed tools.GitHub Actions does not support Python 3.5.1, but I put a request for it actions/setup-python#187.