Skip to content

Fix default in getAuthenticationUrl to pass if requested #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2020

Conversation

rogebrd
Copy link
Contributor

@rogebrd rogebrd commented Oct 15, 2020

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does tox pass?
  • Do the tests pass?

@rogebrd rogebrd requested a review from jiuyangzhao October 15, 2020 20:12
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #271 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   46.91%   46.91%   -0.01%     
==========================================
  Files          31       31              
  Lines       77989    77988       -1     
  Branches     6445     6444       -1     
==========================================
- Hits        36590    36589       -1     
  Misses      41348    41348              
  Partials       51       51              
Flag Coverage Δ
#unit 46.91% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dropbox/oauth.py 55.04% <100.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ca18f...4bfcf99. Read the comment docs.

@rogebrd rogebrd merged commit 43f7191 into master Oct 21, 2020
@rogebrd rogebrd deleted the fix_default_in_auth_url branch October 21, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants