Conversation
Member
Author
|
@guiseco Can you do a code review for the bug fix. |
|
@ne0fhyk what about this way? private void packCircles(List<msg_mission_item> list) {
double altitude = coordinate.getAltitude();
for (int iSteps = 0; iSteps < numberOfSteps ; iSteps++) {
CircleImpl circleImpl = new CircleImpl(missionImpl, new LatLongAlt(coordinate, (altitude)));
circleImpl.setRadius(radius);
list.addAll(circleImpl.packMissionItem());
altitude += heightStep;
}
} |
guiseco
suggested changes
Sep 24, 2016
guiseco
left a comment
There was a problem hiding this comment.
what about this way ?
private void packCircles(List<msg_mission_item> list) {
double altitude = coordinate.getAltitude();
for (int iSteps = 0; iSteps < numberOfSteps ; iSteps++) {
CircleImpl circleImpl = new CircleImpl(missionImpl, new LatLongAlt(coordinate, (altitude)));
circleImpl.setRadius(radius);
list.addAll(circleImpl.packMissionItem());
altitude += heightStep;
}
}
Member
Author
|
@guiseco Thanks for the suggestion! I updated the pull request accordingly. |
|
@ne0fhyk LGTM ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue DroidPlanner/Tower#1810