use access json header / extend error message parsing for stash #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bakito
changed the title
|
@ashwilliams1 sorry had the wrong branch in the PR, it's now corrected and all dev code is removed |
bradrydzewski
approved these changes
Jan 27, 2021
|
When will this be merged and integrated into drone? |
|
Thanks @bakito Looks good merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in https://discourse.drone.io/t/panic-or-undefined-error-when-create-build-from-bitbucket-repository/8549/3
Somehow Bitbucket server does not always return a list of Errors, but only one message with status code.
This PR uses this rool-level message as error if present if the error list is empty.
It also sets the "Accept: application/json" header on the request, since the following code expects the response to be json.