Add support for commit list in push webhook #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks, this looks great. The only feedback I have is we should add the mappings to the Gogs and Gitea drivers as well to ensure all the drivers are in sync and have feature parity: https://github.com/drone/go-scm/blob/master/scm/driver/gogs/testdata/webhooks/push.json#L6:L32 We should also map the commits for Stash, even though we have very limited data in the commit list (just the sha): |
|
Added support for gitea, gogs and stash |
jstrachan
pushed a commit
to jstrachan/go-scm
that referenced
this pull request
Dec 22, 2020
fix: add a Repositories.Create() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for commits in push web hook for GitHub, bitbucket, gitlab, gogs, stash and gitea