Fix Bitbucket link handling for branches with slashes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitbucket has a bug where the "source view" link for a branch which contains a slash results in a 404. The link to the "branch view" works with names containing a slash so we do this for branches with slashes in its names. See https://jira.atlassian.com/browse/BCLOUD-14422 for more information.
|
The suggestions are implemented, any more suggestions? Or is the current pull request good to merge? |
jstrachan
pushed a commit
to jstrachan/go-scm
that referenced
this pull request
Dec 22, 2020
fix: Add fake implementation for Status operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitbucket has a bug where the "source view" link for a branch
which contains a slash results in a 404.
The link to the "branch view" works with names containing
a slash so we do this for branches with slashes in its names.
See https://jira.atlassian.com/browse/BCLOUD-14422 for more information.