fetch branch for bitbucket onprem #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devkimittal
force-pushed
the
devmittal
branch
2 times, most recently
from
dd80adf to
9a512d7
Compare
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "id": "refs/heads/mohit/mohit-temp", | |||
There was a problem hiding this comment.
nit: Prefer adding generic names
| @@ -3,7 +3,7 @@ | |||
| "Namespace": "PRJ", | |||
| "Name": "my-repo", | |||
| "Perm": null, | |||
| "Branch": "master", | |||
| "Branch": "notmaster", | |||
There was a problem hiding this comment.
nit: feature_branch
| @@ -22,6 +22,7 @@ | |||
| "stash.go", | |||
| "stash_test.go", | |||
| "testdata/branch.json", | |||
| "testdata/default_branch.json", | |||
There was a problem hiding this comment.
Don't you have to add golden as well here?
nit: Alphabetical order
| @@ -75,6 +75,10 @@ | |||
| "path": "testdata/branch.json", | |||
| "kind": "file" | |||
| }, | |||
| { | |||
devkimittal
force-pushed
the
devmittal
branch
from
9a512d7 to
2a53c8e
Compare
|
@rutvijmehta-harness made the changes according to your comments. |
devkimittal
force-pushed
the
devmittal
branch
from
2a53c8e to
df6c516
Compare
rutvijmehta-harness
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.