Bitbucket sha fix for merged pr #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raghavharness please keep in mind that there are multiple consumers of this library, and that changes made for Harness have the potential to break other consumers, such as Drone. For example, when Drone executes a pipeline for a pull request, it clones the base branch and then manually performs the merge. Moving from commit sha to merge sha would break the clone step in Drone for Bitbucket. Instead of changing the behavior of an existing field, I have added a new |
bradrydzewski
requested changes
Sep 14, 2022
|
Sure, thanks @bradrydzewski for the inputs. |
|
@bradrydzewski @tphoney Have addressed your comment, can you please review once. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For bitbucket, since we don't have pull-request refs so we use source branch to clone the PR. But in cases where source branch is deleted when pr is merged, git clone gets failed. To prevent that we'll use the merge commit instead of source branch latest commit.