support parsing unknown event types

drone · Dec 1, 2020 · ffa46d9 · ffa46d9
1 parent ff8ad5b
commit ffa46d9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/scm/const.go b/scm/const.go
@@ -27,7 +27,8 @@ type Action int
 
 // Action values.
 const (
-	ActionCreate Action = iota + 1
+	ActionUnknown Action = iota
+	ActionCreate
 	ActionUpdate
 	ActionDelete
 	// issues

diff --git a/scm/driver/github/webhook.go b/scm/driver/github/webhook.go
@@ -125,8 +125,6 @@ func (s *webhookService) parsePullRequestHook(data []byte) (scm.Webhook, error)
 	}
 	dst := convertPullRequestHook(src)
 	switch src.Action {
-	case "assigned", "unassigned", "review_requested", "review_request_removed":
-		return nil, nil
 	case "labeled":
 		dst.Action = scm.ActionLabel
 	case "unlabeled":
@@ -136,13 +134,21 @@ func (s *webhookService) parsePullRequestHook(data []byte) (scm.Webhook, error)
 	case "edited":
 		dst.Action = scm.ActionUpdate
 	case "closed":
+		// TODO(bradrydzewski) github does not provide a merged action,
+		// but this is provided by gitlab and bitbucket. Is it possible
+		// to emulate the merge action?
+
 		// if merged == true
 		//    dst.Action = scm.ActionMerge
 		dst.Action = scm.ActionClose
 	case "reopened":
 		dst.Action = scm.ActionReopen
 	case "synchronize":
 		dst.Action = scm.ActionSync
+	case "assigned", "unassigned", "review_requested", "review_request_removed", "ready_for_review", "locked", "unlocked":
+		dst.Action = scm.ActionUnknown
+	default:
+		dst.Action = scm.ActionUnknown
 	}
 	return dst, nil
 }