[feat]: [CDS-73572]: review comments in corporated

scm/driver/github/repo.go

@@ -119,7 +119,7 @@ func (s *RepositoryService) ListV2(ctx context.Context, opts scm.RepoListOptions
 	path := fmt.Sprintf("search/repositories?%s", formRepoListQueryParams(opts))
 	out := new(searchRepositoryList)
 	res, err := s.client.do(ctx, "GET", path, nil, &out)
-	return convertSearchRepositoryList(out), res, err
+	return convertRepositoryList(out.Repositories), res, err
 }
 
 // List returns the github app installation repository list.
@@ -234,18 +234,6 @@ func convertRepositoryList(from []*repository) []*scm.Repository {
 	return to
 }
 
-// helper function to convert from the gogs items list to
-// the common repository structure.
-func convertSearchRepositoryList(from *searchRepositoryList) []*scm.Repository {
-	to := []*scm.Repository{}
-	for _, v := range from.Repositories {
-		if repo := convertRepository(v); repo != nil {
-			to = append(to, repo)
-		}
-	}
-	return to
-}
-
 // helper function to convert from the gogs repository structure
 // to the common repository structure.
 func convertRepository(from *repository) *scm.Repository {

scm/driver/gitlab/repo.go

@@ -95,6 +95,7 @@ func (s *repositoryService) List(ctx context.Context, opts scm.ListOptions) ([]*
 }
 
 func (s *repositoryService) ListV2(ctx context.Context, opts scm.RepoListOptions) ([]*scm.Repository, *scm.Response, error) {
+	// We pass the repo searchTerm in the query params and gitlab filters repos based on this search term
 	path := fmt.Sprintf("api/v4/projects?%s", encodeRepoMemberListOptions(opts))
 	out := []*repository{}
 	res, err := s.client.do(ctx, "GET", path, nil, &out)