feat: [CI-14390]: Added new enhancements to plugins/jira
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanisrikanithi
changed the title
Ompragash
requested changes
Sep 26, 2024
plugin/plugin.go
Outdated
| State: state, | ||
| UpdateSequenceNumber: args.Build.Number, | ||
| References: []struct { |
There was a problem hiding this comment.
add a check to make sure the branch and URI values exist before adding them to the References so it'll only be added when the necessary values are available
Ompragash
changed the title
plugins/jira
util_test.go updated with unit tests for new functions. In plugin.go not implemented any new
|
|
Review comments addressed and updated the new patch. |
Ompragash
requested changes
Oct 1, 2024
…rus for printing log messages
|
@Ompragash @jamie-harness I have addressed the review comments. Please take a look at the latest changes. |
Ompragash
requested changes
Oct 4, 2024
Ompragash
reviewed
Oct 4, 2024
Ompragash
reviewed
Oct 4, 2024
Ompragash
approved these changes
Oct 4, 2024
This was referenced Nov 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This review covers all Jira issues #21,#22,#23,#24 as per jira spec.
There are some commented lines which are used for debugging. once the review is approved, will remove them.