Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negotiate API Version #72

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Negotiate API Version #72

merged 2 commits into from
Aug 26, 2020

Conversation

donny-dont
Copy link
Contributor

The docker.NewClient function is deprecated for docker.NewClientWithOpts. Specify the already present options but also use API negotiation rather than using the explicit default version.

The `docker.NewClient` function is deprecated for `docker.NewClientWithOpts`. Specify the already present options but also use API negotiation rather than using the explicit default version.
@donny-dont
Copy link
Contributor Author

@bradrydzewski so either we can use this or use the FromEnv like what you are doing at https://github.com/drone-runners/drone-runner-docker/blob/master/engine/engine.go#L47 just let me know your preference.

@bradrydzewski bradrydzewski merged commit 31d54f7 into drone:master Aug 26, 2020
@donny-dont donny-dont deleted the patch-1 branch August 26, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants