[#513] Virtual thread pin event metric and alarm #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ISSUE dromara#515] add scheduledFuture cancel check
…nto springboot3
|
代码改的太乱，改动太大了。我理解这是一个新功能，期望的应该是以最小代价、最小改动集成进去，对扩展开放，对修改关闭，而不是大量改动现有逻辑，分散在其中。 |
yanhom1314
reviewed
Feb 12, 2025
| public static final String LARK_ALARM_JSON_COMMON_STR = | ||
| "{\"tag\":\"div\",\"fields\":[{\"is_short\":true,\"text\":{\"tag\":\"lark_md\",\"content\":\"%s\"}}]},"; | ||
|
|
||
| public static final String LARK_ALARM_JSON_STR_SUFFIX = |
There was a problem hiding this comment.
这是一个完整的json，不要拆分开，很难维护，格式容易配置错
| /** | ||
| * Pin timeout alarm. | ||
| */ | ||
| PIN_TIMEOUT("pin_timeout", ""); |
There was a problem hiding this comment.
这个不要归类到该枚举里，枚举里是线程池层面常规项，这个加入不太合适
| /** | ||
| * 拓展字段 | ||
| */ | ||
| private final Map<String, Double> extMap = new ConcurrentHashMap<>(2); |
There was a problem hiding this comment.
扩展字段类型可以是任意，不要用double，用Object，初始长度不用指定
| @@ -102,11 +102,16 @@ public static List<NotifyItem> getAllNotifyItems() { | |||
| queueTimeoutNotify.setType(NotifyItemEnum.QUEUE_TIMEOUT.getValue()); | |||
| queueTimeoutNotify.setThreshold(10); | |||
|
|
|||
| List<NotifyItem> notifyItems = new ArrayList<>(6); | |||
| NotifyItem pinTimeoutNotify = new NotifyItem(); | |||
| pinTimeoutNotify.setType(NotifyItemEnum.PIN_TIMEOUT.getValue()); | |||
| @@ -220,6 +221,10 @@ private static void refresh(ExecutorWrapper executorWrapper, DtpExecutorProps pr | |||
|
|
|||
| private static void doRefresh(ExecutorWrapper executorWrapper, DtpExecutorProps props) { | |||
| ExecutorAdapter<?> executor = executorWrapper.getExecutor(); | |||
| if (executorWrapper.isVirtualThreadExecutor()) { | |||
| doRefreshCommon(executorWrapper, props); | |||
| NotifyItem notifyItem = DtpNotifyCtxHolder.get().getNotifyItem(); | ||
| BaseNotifyCtx notifyCtx = DtpNotifyCtxHolder.get(); | ||
| if (notifyCtx.isToLog()) { | ||
| log.warn("DynamicTp alarm, executor [" + notifyCtx.getExecutorWrapper().getThreadPoolName() + "]: \n" + Arrays.toString(notifyCtx.getContent())); |
| if (notifyCtx.isCommonNotify()) { | ||
| notifier.sendCommonAlarmMsg(p, notifyItemEnum, notifyCtx.getContent()); | ||
| } else { | ||
| if (!notifyCtx.getExecutorWrapper().isVirtualThreadExecutor()) { |
| @@ -35,11 +35,24 @@ public class BaseNotifyCtx { | |||
|
|
|||
| private NotifyItem notifyItem; | |||
|
|
|||
| private boolean isCommonNotify; | |||
|
|
|||
| private boolean isToLog; | |||
| @@ -88,12 +89,22 @@ public void sendAlarmMsg(NotifyPlatform notifyPlatform, NotifyItemEnum notifyIte | |||
| notifier.send(newTargetPlatform(notifyPlatform), content); | |||
| } | |||
|
|
|||
| @Override | |||
| public void sendCommonAlarmMsg(NotifyPlatform notifyPlatform, NotifyItemEnum notifyItemEnum, String... content) { | |||
There was a problem hiding this comment.
通用告警接口期望的是调用方传进来最终content，直接发送，不用再做组装
|
编译时需要将core，spring模块的JDK版本更改为21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#513] Virtual thread pin event metric and alarm