(FEAT)[#422] Router - 추가 적용#520
Merged
taehwandev merged 39 commits intodroidknights:2025/appfrom Jun 12, 2025
Merged
Conversation
…iewModelTest navigator 생성자 추가
…함수 수정 및 사용하지 않는 MainNavigator 코드 제거
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 644dda6. ♻️ This comment has been updated with latest results. |
Member
|
바텀 탭 루트 객체도 각각 feature-api 모듈로 분리 해야할까요?
|
Member
|
@s9hn ./gradlew/detekt 로컬에서 체크 부탁드립니다. |
taehwandev
reviewed
Jun 9, 2025
| restoreState = true | ||
| } | ||
| restoreState = sideEffect.saveState | ||
| launchSingleTop = sideEffect.launchSingleTop |
taehwandev
reviewed
Jun 9, 2025
| navController: NavHostController = rememberNavController(), | ||
| ): MainNavigator = remember(navController) { | ||
| MainNavigator(navController) | ||
| MainNavigator(navController, onTabClick) |
Member
There was a problem hiding this comment.
이 라우터 작업은 이 부분을 제거하기 위함이긴 합니다.
view > viewModel에서 각각의 navigate 처리를 하기 위함.
Contributor
Author
There was a problem hiding this comment.
안녕하세요 태환님 리뷰 감사드립니다.
구현을 고민해보며 MainNavigator에서 MainViewModel을 통한 Navigate가 아닌,
탭 선택 시 상태를 각 스크린에 전파하고 각 스크린의 뷰모델이 Navigate 책임을 이행하도록 수정했습니다.
MainNavigator는 내부적으로 NavController와 MainTab을 활용해 탭 네비게이팅 관련 API를 잘 캡슐화하고 있다고 판단해 그대로 두었습니다.
Member
|
@s9hn 컴플릭 한번 더 확인 부탁드려요. 수정이 많아서 뒷단에서... |
…함수 수정 및 사용하지 않는 MainNavigator 코드 제거
Contributor
Author
|
리베이스를 잘못건드려서 삽질을 좀..했습니다 |
Member
|
@s9hn 고생하셨습니다! 생소한 패턴이였을건데 이 부분 이해하시고 적용에 감사드립니다! |
Member
|
머지 후 수정하겠습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Problem
saveState분기에 맞추어popUpTo를 호출하도록 구현했습니다.launchSingleTop옵션을 사용할 수 없어 이를 추가했습니다.[App] ScreenTest Hilt 빌드 에러 해결 #521 해당 이슈에서 작업하겠습니다.
Question
Screenshot
Links