Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl.c: fix integer overflow found by Svace: #327

Merged
merged 1 commit into from
May 17, 2023

Conversation

disaykin
Copy link
Contributor

The value of an arithmetic expression p[1] + (p[0] << 8) is subject
to overflow due to a failure to cast operands to a larger data type
before perfoming arithmetic

    The value of an arithmetic expression p[1] + (p[0] << 8) is subject
    to overflow due to a failure to cast operands to a larger data type
    before perfoming arithmetic
@sonertari
Copy link
Collaborator

Afaik, @droe prefers macros in such cases, but it's looking good to me.

@sonertari sonertari merged commit 69e67fb into droe:develop May 17, 2023
@disaykin disaykin deleted the fix-ssl-integer-overflow branch July 2, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants