Skip to content

Commit

Permalink
Use github pull-request terminology instead of gitlab merge-request. …
Browse files Browse the repository at this point in the history
…Remove unnescesary line breaks, and add clarity to finding the first issue sentence (nv-morpheus#40)
  • Loading branch information
dagardner-nv authored Apr 26, 2022
1 parent cf0c906 commit f018b05
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,28 +25,22 @@ More information can be found at: [Contributor Code of Conduct](CODE_OF_CONDUCT.

### Your first issue

1. Find an issue to work on. The best way is to look for the [good first issue](https://github.com/NVIDIA/Morpheus/issues).
1. Find an issue to work on. The best way is to look for issues with the [good first issue](https://github.com/NVIDIA/Morpheus/issues) label.
2. Comment on the issue stating that you are going to work on it.
3. Code! Make sure to update unit tests! Ensure the [license headers are set properly](#Licensing).
4. When done, [create your merge request](https://github.com/NVIDIA/Morpheus/compare).
5. Wait for other developers to review your code and update code as needed.
6. Once reviewed and approved, a Morpheus developer will merge your merge request.
6. Once reviewed and approved, a Morpheus developer will merge your pull request.

Remember, if you are unsure about anything, don't hesitate to comment on issues
and ask for clarifications!
Remember, if you are unsure about anything, don't hesitate to comment on issues and ask for clarifications!

### Seasoned developers

Once you have gotten your feet wet and are more comfortable with the code, you
can look at the prioritized issues for our next release in our [project boards](https://github.com/NVIDIA/Morpheus/projects).
Once you have gotten your feet wet and are more comfortable with the code, you can look at the prioritized issues for our next release in our [project boards](https://github.com/NVIDIA/Morpheus/projects).

> **Pro Tip:** Always look at the release board with the highest number for
issues to work on. This is where Morpheus developers also focus their efforts.
> **Pro Tip:** Always look at the release board with the highest number for issues to work on. This is where Morpheus developers also focus their efforts.
Look at the unassigned issues, and find an issue to which you are comfortable
contributing. Start with _Step 2_ above, commenting on the issue to let
others know you are working on it. If you have any questions related to the
implementation of the issue, ask them in the issue instead of the MR.
Look at the unassigned issues, and find an issue to which you are comfortable contributing. Start with _Step 2_ above, commenting on the issue to let others know you are working on it. If you have any questions related to the implementation of the issue, ask them in the issue instead of the PR.

## Setting Up Your Build Environment

Expand Down

0 comments on commit f018b05

Please sign in to comment.