Repository navigation
Bug: package-manifest-consistency-residuals #929
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
- Work Mode: minor-audit
Summary
Consolidates #912 with the remaining parts of #914. PRs #920 and #921 fixed 8 of the 10 stale binding redirects and the Invoke-ProjectConsistencyRepair fallback defect. All remaining items break one invariant: a project's files and its own packages.config must agree, and the repair workflow that maintains them must be runnable.
- Bug: quickfiler-test-imports-altcover-absent-from-manifest #912:
QuickFiler.Test/QuickFiler.Test.csprojlines 8 and 535 importaltcover.8.6.45build assets. Nopackages.configdeclaresaltcover, so the imports are silently skipped by theirExists()guard. - Bug: dependabot-repair-deferred-credential-criteria-and-residuals (follow-up to #911) #914 sub-item 3 residual: two binding redirects in
SVGControl/app.configare still stale:Fizzlerredirects to 1.3.0.0, but the reference and the restored package are 1.3.1.0.System.Runtime.CompilerServices.Unsaferedirects to 6.0.2.0, but the reference and the restored package are 6.0.3.0.
- Bug: dependabot-repair-deferred-credential-criteria-and-residuals (follow-up to #911) #914 comment item 1:
.github/workflows/dependabot-repair.yml:51passes the deprecatedapp-idinput toactions/create-github-app-token@v3. It should passclient-id, and the runbook should say to store the App's Client ID. - Bug: dependabot-repair-deferred-credential-criteria-and-residuals (follow-up to #911) #914 sub-item 1 (verification only, requires the maintainer): AC18, AC19 and AC20 of Bug: dependabot-fanout-and-ci-failing-nuget-upgrades #911 can only be exercised after a GitHub App credential is provisioned. The runbook is at
docs/features/active/2026-09-19-dependabot-fanout-and-ci-failing-nuget-upgrades-911/runbooks/github-app-installation-token.runbook.md. The secret store is also unconfirmed: a Dependabot-triggeredworkflow_runmay read only Dependabot secrets. None of this is a merge gate for items 1 to 3.
Environment
- OS/version: Windows 11 Pro 10.0.26200
- Python version: not applicable (.NET Framework 4.8.1 packages.config projects, GitHub Actions)
- Command/flags used:
nuget restore TaskMaster.slnfrom cold; static inspection onmainat177b6d78e - Data source or fixture:
QuickFiler.Test/QuickFiler.Test.csproj,QuickFiler.Test/packages.config,SVGControl/app.config,SVGControl/packages.config,.github/workflows/dependabot-repair.yml
Steps to Reproduce
git grep -n altcover -- "*.csproj" "*packages.config"finds two imports and no manifest entry.- Compare the
SVGControl/app.configbindingRedirect newVersionvalues forFizzlerandSystem.Runtime.CompilerServices.Unsafewith the referenced assembly versions. - Read
dependabot-repair.yml:51.
Expected Behavior
- Every
..\packages\import corresponds to a manifest entry. - Every binding redirect names the assembly version that actually ships.
- The repair workflow uses the non-deprecated input.
Actual Behavior
As listed in the Summary.
Logs / Screenshots
- Attached minimal logs or snippet
- Snippet: run https://github.com/drmoisan/TaskMaster/actions/runs/36281113978 fails at
Mint an installation tokenwith the deprecation warning forapp-id(see the Bug: dependabot-repair-deferred-credential-criteria-and-residuals (follow-up to #911) #914 comment of 2026-09-26).
Impact / Severity
- Blocker
- High
- Medium
- Low
Source
From: docs/features/potential/2026-09-28-package-manifest-consistency-residuals.md
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Activity
drmoisan commentedon Sep 28, 2026
The following sections were present in the promoted potential entry (
docs/features/potential/promoted/2026-09-28-package-manifest-consistency-residuals.md) but were dropped bypotential_to_issue(defect #887, now consolidated into #932). Reposted verbatim.Suspected Cause / Notes
SVGControlwas left in place.Proposed Fix / Validation Ideas
<Import>elements. AltCover is not used by the coverage route, which isdotnet-coverage.SVGControl/app.configredirects, preferably by runningscripts/dependencies/Repair-PackageManifestConsistency.ps1rather than editing by hand.app-idtoclient-idin the workflow, update the runbook, and confirm with actionlint.Next Step
Consolidates: #912, #914 (sub-items 1, 3 residual, and the
client-idcomment). #914 sub-item 2 moved to the coverage-runner item. #914 sub-item 4 is fixed by PR #920.drmoisan commentedon Sep 30, 2026
Delivered by PR 949 (merge commit 66afa63), parallel run bugs-2026-09-28. All 7 acceptance criteria in issue.md are checked off; all seven checks green on head 2158615 (run 36729139161) before merge. Issue 911 AC18 to AC20 remain a maintainer follow-up (DEPENDABOT_REPAIR_APP_ID must hold the App Client ID); other follow-ups are filed separately by the run coordinator.