Beta: fix non-UTC year being used in UTC timestamp #5202
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generated a migration before midnight in my timezone on Dec 31 and noticed that drizzle-kit generated a migration timestamped before my other migrations with the prefix 20250101. This happened because even though it was 2025 in my timezone, it was 2026 in UTC time, and
prepareSnapshotFolderNameusesgetFullYearwhen it should usegetUTCFullYear. This PR fixes that.Example:
prepareSnapshotFolderName(1767243310815)Returned:
'20250101045510'Expected:
'20260101045510'