[Pg] Fix geometry column type ignoring config options in SQL generation #5160
+35
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The geometry() column type accepts config options (type, srid, mode) but getSQLType() was hardcoded to return 'geometry(point)' regardless of config. Changes: - Update PgGeometryBuilder and PgGeometryObjectBuilder to accept and store type and srid config options - Update PgGeometry and PgGeometryObject to use config in getSQLType() - Update geometry() function to pass config to builders Now geometry columns correctly generate SQL like: - geometry(multipolygon,4326) when both type and srid specified - geometry(multipolygon) when only type specified - geometry(point) as default
edwardwc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The geometry() column type accepts config options (type, srid, mode) but getSQLType() was hardcoded to return 'geometry(point)' regardless of config.
Changes:
Now geometry columns correctly generate SQL like: