SQLite onConflict chaining fix #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added related tests, removed unused import
|
@Sukairo-02 Probably worth mentioning that this RP would close #2276. |
…es on type level, added `View` support to `aliasedTable()`, fixed sql builder prefixing aliased views and tables with their schema names
|
And #3491 too. |
drizzle-orm/src/alias.ts
Outdated
| @@ -88,8 +93,15 @@ export class RelationTableAliasProxyHandler<T extends Relation> implements Proxy | |||
| } | |||
| } | |||
|
|
|||
| export function aliasedTable<T extends Table>(table: T, tableAlias: string): T { | |||
| return new Proxy(table, new TableAliasProxyHandler(tableAlias, false)); | |||
| export function aliasedTable<T extends Table | View, TAlias extends string>( | |||
There was a problem hiding this comment.
maybe we need to separate it to each dialect
| const sqlitevUsers = sqliteView('users_view').as((qb) => qb.select().from(sqliteUsers)); | ||
| const mysqlvUsers = mysqlView('users_view').as((qb) => qb.select().from(mysqlUsers)); | ||
|
|
||
| const pgAlias = aliasedTable(pgUsers, 'usersAlias'); |
…c `alias` functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onConflictclauses being overwritten instead of stacked (fixes [FEATURE]: Support multiple onConflictDoUpdate's #2276)aliasedTable()function (requested in [FEATURE]: Ability to use an aliased view #3491)Made- removed in favor of dialect-specificaliasedTable()function same asalias()functions on type-level (fixesaliasedTable()not aliasing tables on type level)alias()functions