Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use abc.ABC as baseclass for AnyPath to fix issubclass behavior (#251) #257

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Aug 18, 2022

  • Use abc.ABC as baseclass for AnyPath

  • add type ignore for ABC.register


Local branch to run live tests

* Use abc.ABC as baseclass for AnyPath

* add type ignore for ABC.register
@github-actions
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #257 (b5cdc3f) into master (1f28327) will decrease coverage by 0.3%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #257     +/-   ##
========================================
- Coverage    94.8%   94.4%   -0.4%     
========================================
  Files          21      21             
  Lines        1323    1321      -2     
========================================
- Hits         1255    1248      -7     
- Misses         68      73      +5     
Impacted Files Coverage Δ
cloudpathlib/anypath.py 100.0% <100.0%> (ø)
cloudpathlib/s3/s3client.py 92.9% <0.0%> (-2.7%) ⬇️
cloudpathlib/gs/gsclient.py 92.8% <0.0%> (-1.8%) ⬇️

@pjbull pjbull merged commit c9eddab into master Aug 18, 2022
@pjbull
Copy link
Member Author

pjbull commented Aug 18, 2022

Thanks @chbehrens!

@pjbull pjbull deleted the 251-live-tests branch August 18, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants