Fix: Create budget and remaining budget not working (#53)

* Fix: Create budget and remaining budget not working
drishit96 · Dec 21, 2023 · 2cd09a7 · 2cd09a7
1 parent 13b9aae
commit 2cd09a7
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 27 deletions.
diff --git a/app/components/TargetSetter.tsx b/app/components/TargetSetter.tsx
@@ -145,15 +145,20 @@ export default function TargetSetter({
   }, [categoryBudgets]);
 
   useEffect(() => {
-    if (previousBudgetFetcher.type === "done") {
-      if (previousBudgetFetcher.data && previousBudgetFetcher.data.length > 0) {
-        setCategoryBudgets([...categoryBudgets, ...previousBudgetFetcher.data]);
-        setMaxKey(previousBudgetFetcher.data.length);
+    if (previousBudgetFetcher.data != null) {
+      const budgetData = previousBudgetFetcher.data as {
+        index: number;
+        category: string;
+        budget: string;
+      }[];
+      if (budgetData.length > 0) {
+        setCategoryBudgets([...categoryBudgets, ...budgetData]);
+        setMaxKey(budgetData.length);
       } else {
         context.setSnackBarMsg("No budget found for previous month");
       }
     }
-  }, [previousBudgetFetcher.type]);
+  }, [previousBudgetFetcher.data]);
 
   return (
     <>

diff --git a/app/routes/transaction/create.tsx b/app/routes/transaction/create.tsx
@@ -279,18 +279,16 @@ export default function Create() {
   }, [selectedCategories]);
 
   useEffect(() => {
-    if (categoryRemainingBudgetFetcher.type === "done") {
-      if (categoryRemainingBudgetFetcher.data) {
-        categoryRemainingBudgetMap.current = {
-          ...categoryRemainingBudgetMap.current,
-          ...(categoryRemainingBudgetFetcher.data as {
-            [key: string]: number | null;
-          }),
-        };
-        calculateRemainingBudget(amount);
-      }
+    if (categoryRemainingBudgetFetcher.data) {
+      categoryRemainingBudgetMap.current = {
+        ...categoryRemainingBudgetMap.current,
+        ...(categoryRemainingBudgetFetcher.data as {
+          [key: string]: number | null;
+        }),
+      };
+      calculateRemainingBudget(amount);
     }
-  }, [amount, calculateRemainingBudget, categoryRemainingBudgetFetcher]);
+  }, [amount, calculateRemainingBudget, categoryRemainingBudgetFetcher.data]);
 
   useEffect(() => {
     calculateRemainingBudget(amount);

diff --git a/app/routes/transaction/edit/$transactionId.tsx b/app/routes/transaction/edit/$transactionId.tsx
@@ -281,18 +281,16 @@ export default function EditTransaction() {
   }, [selectedCategories]);
 
   useEffect(() => {
-    if (categoryRemainingBudgetFetcher.type === "done") {
-      if (categoryRemainingBudgetFetcher.data) {
-        categoryRemainingBudgetMap.current = {
-          ...categoryRemainingBudgetMap.current,
-          ...(categoryRemainingBudgetFetcher.data as {
-            [key: string]: number | null;
-          }),
-        };
-        calculateRemainingBudget(amount);
-      }
+    if (categoryRemainingBudgetFetcher.data) {
+      categoryRemainingBudgetMap.current = {
+        ...categoryRemainingBudgetMap.current,
+        ...(categoryRemainingBudgetFetcher.data as {
+          [key: string]: number | null;
+        }),
+      };
+      calculateRemainingBudget(amount);
     }
-  }, [amount, calculateRemainingBudget, categoryRemainingBudgetFetcher]);
+  }, [amount, calculateRemainingBudget, categoryRemainingBudgetFetcher.data]);
 
   useEffect(() => {
     calculateRemainingBudget(amount);