Gradle Plugin: Switch extension to a (safe) interface #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewhamilton
approved these changes
Jan 16, 2026
Owner
drewhamilton
left a comment
drewhamilton
left a comment
There was a problem hiding this comment.
Nice, thanks. If there's no pressing need, I'll hold onto this until another breaking change has to be made. This will be for Kotlin 2.4.0 at latest.
Contributor
Author
|
There is no pressing need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually creating the
PropertyviaObjectFactory, you should use an abstract member.Also, Gradle prefers a safe interface, this will be enforced (with opt-out) via the upcoming Declarative DSL, but it is nice to enforce it as a best practice now too.
Safe means:
gradle/gradle#35926 (comment)