Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect final Poko functions in superclass #473

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

drewhamilton
Copy link
Owner

Fixes #471. Now, if a Poko class's superclass has a final override of any of the Poko functions, Poko does not generate an override of that function. Implemented for both the standard IR generation and the in-progress FIR generation.

@drewhamilton drewhamilton enabled auto-merge (squash) January 17, 2025 21:55
@drewhamilton drewhamilton merged commit 332275e into main Jan 17, 2025
9 checks passed
@drewhamilton drewhamilton deleted the drew/superclass-with-final-overrides branch January 17, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handling of superclass with final Poko function overrides
1 participant