Clarified 'enable_terminal' workflow_dispatch label.#2504
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
WalkthroughThis PR clarifies the wording of the ChangesTerminal Session Documentation Clarification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2504 +/- ##
=======================================
Coverage 69.56% 69.56%
=======================================
Files 43 43
Lines 2602 2602
Branches 3 3
=======================================
Hits 1810 1810
Misses 792 792 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
The
enable_terminalworkflow_dispatchinput had a generic label ("Enable terminal session") that did not make clear it applies specifically to CI jobs rather than a local or general-purpose terminal. The label has been updated to "Enable terminal session for CI jobs" to eliminate that ambiguity. The corresponding docs paragraph has been updated to match.Changes
Workflow file (
.github/workflows/build-test-deploy.yml):enable_terminal.descriptionfrom'Enable terminal session'to'Enable terminal session for CI jobs'Documentation (
.vortex/docs/content/continuous-integration/github-actions.mdx):Snapshot fixtures (auto-regenerated):
.vortex/installer/tests/Fixtures/handler_process/_baseline/.github/workflows/build-test-deploy.yml.vortex/installer/tests/Fixtures/handler_process/provision_profile/.github/workflows/build-test-deploy.ymlBefore / After
The label shown in the GitHub Actions "Run workflow" form:
Docs paragraph (before):
Docs paragraph (after):
Summary by CodeRabbit
Documentation
Chores