[#1618] Fixed self-hosted Renovate runs without RENOVATE_TOKEN set.
#1646
Conversation
WalkthroughConditional checks were introduced in both CircleCI and GitHub Actions configuration files to ensure that dependency update jobs only run when the Changes
Sequence Diagram(s)sequenceDiagram
participant CI_System as CI System (CircleCI/GitHub Actions)
participant RenovateJob as Deps-Updates Job
CI_System->>RenovateJob: Start job
RenovateJob->>RenovateJob: Check if RENOVATE_TOKEN is set
alt RENOVATE_TOKEN is set and non-empty
RenovateJob->>RenovateJob: Run Renovate commands
else RENOVATE_TOKEN is missing or empty
RenovateJob->>RenovateJob: Print skip message and exit
end
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.circleci/config.yml(1 hunks).github/workflows/deps-updates.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/deps-updates.yml
10-10: context "secrets" is not allowed here. available contexts are "github", "inputs", "needs", "vars". see https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for more details
(expression)
🪛 GitHub Actions: Vortex - Test installer
.github/workflows/deps-updates.yml
[error] 7-13: PHPUnit test failures due to content differences in '.github/workflows/deps-updates.yml'. The file has an unexpected additional line: 'if: ${{ secrets.RENOVATE_TOKEN != '' }}' in the 'deps-updates' job steps.
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: build (0)
- GitHub Check: build (1)
- GitHub Check: vortex-test-workflow (2)
- GitHub Check: vortex-test-workflow (3)
- GitHub Check: vortex-test-workflow (1)
- GitHub Check: vortex-test-workflow (0)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1646 +/- ##
========================================
Coverage 71.56% 71.56%
========================================
Files 76 76
Lines 4308 4308
========================================
Hits 3083 3083
Misses 1225 1225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skipper-vp
force-pushed
the
feature/1618-renovate-token-check
branch
from
e6754c3 to
dbe40b9
Compare
skipper-vp
force-pushed
the
feature/1618-renovate-token-check
branch
from
dbe40b9 to
d9280d7
Compare
skipper-vp
force-pushed
the
feature/1618-renovate-token-check
branch
from
d9280d7 to
6ccd30c
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
♻️ Duplicate comments (1)
.circleci/config.yml (1)
424-431: 🧹 Nitpick (assertive)Early bypass for missing RENOVATE_TOKEN
This step gracefully halts thedeps-updatesjob whenRENOVATE_TOKENis unset, preventing unnecessary Renovate execution.
- Duplicate: consider moving this check before the
checkoutstep to avoid cloning the repository when the token is missing.- To reduce duplication, extract this block into a shared YAML anchor that can be reused in all CircleCI configs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Lite
📒 Files selected for processing (8)
.circleci/config.yml(1 hunks).github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/ciprovider_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml(1 hunks)
🔇 Additional comments (3)
.vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml (1)
5-6: Updated default Renovate commit author email
The fallbackRENOVATE_GIT_AUTHORwas changed to userenovatebot@the-new-hope-domain.example. This update looks correct. Please verify that this new email is consistently applied across all GitHub Actions workflows that setRENOVATE_GIT_AUTHOR..vortex/installer/tests/Fixtures/install/ciprovider_circleci/.circleci/config.yml (1)
398-405: Add pre-check forRENOVATE_TOKENto skip Renovate job when token is missingThe new
runstep correctly exits early ifRENOVATE_TOKENis unset or empty, usingcircleci-agent step haltandexit 0to prevent subsequent Renovate commands from running. This aligns with the updates in other CircleCI configs..github/workflows/deps-updates.yml (1)
18-26: Conditionally skip Renovate step based on token presenceThe
Check Renovate Tokenstep properly uses a shell guard to settoken_existsonly whensecrets.RENOVATE_TOKENis non-empty, and theif: steps.check-token.outputs.token_exists == 'true'on theSelf-hosted Renovatestep cleanly prevents the action from running without a token.Also applies to: 29-30
| - run: | ||
| name: Check if RENOVATE_TOKEN is set | ||
| command: | | ||
| if [ -z "${RENOVATE_TOKEN}" ]; then | ||
| echo "RENOVATE_TOKEN is not set. Skipping Renovate job." | ||
| circleci-agent step halt | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Skip Renovate job when RENOVATE_TOKEN is unset
The new guard halts the step with a zero exit code if RENOVATE_TOKEN is empty or missing, which is the desired behavior.
To improve maintainability across multiple fixture configs, consider defining this check as a reusable YAML anchor.
🤖 Prompt for AI Agents
In
.vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml
around lines 398 to 405, the check for RENOVATE_TOKEN being set is duplicated in
multiple fixture configs. Refactor this by defining the check as a reusable YAML
anchor at a common location in the config file, then reference this anchor
wherever the check is needed. This will improve maintainability by centralizing
the logic and avoiding repetition.
| - run: | ||
| name: Check if RENOVATE_TOKEN is set | ||
| command: | | ||
| if [ -z "${RENOVATE_TOKEN}" ]; then | ||
| echo "RENOVATE_TOKEN is not set. Skipping Renovate job." | ||
| circleci-agent step halt | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Early exit for missing Renovate token
This addition checks for RENOVATE_TOKEN and halts the step if it's not provided, effectively skipping Renovate steps.
Consider extracting this logic into a common YAML anchor to avoid repeating it in each CircleCI configuration.
🤖 Prompt for AI Agents
In
.vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml
around lines 352 to 359, the check for the RENOVATE_TOKEN environment variable
is duplicated in multiple places. To fix this, extract the if-condition and
related commands into a reusable YAML anchor or command that can be referenced
wherever needed. This will reduce repetition and improve maintainability of the
CircleCI configuration.
| - run: | ||
| name: Check if RENOVATE_TOKEN is set | ||
| command: | | ||
| if [ -z "${RENOVATE_TOKEN}" ]; then | ||
| echo "RENOVATE_TOKEN is not set. Skipping Renovate job." | ||
| circleci-agent step halt | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Guard against absent RENOVATE_TOKEN
The step correctly halts the job when RENOVATE_TOKEN is unset, preventing further Renovate commands.
As this snippet is duplicated in multiple CircleCI configs, extracting it into an anchor would adhere to DRY principles.
🤖 Prompt for AI Agents
In
.vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml
around lines 398 to 405, the check for the RENOVATE_TOKEN environment variable
is duplicated in multiple places. To follow DRY principles, extract this snippet
into a YAML anchor at a common location in the config file, then reference this
anchor wherever the check is needed. This will centralize the logic and avoid
repetition.
.vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml
Show resolved
Hide resolved
skipper-vp
force-pushed
the
feature/1618-renovate-token-check
branch
from
6ccd30c to
cd6eb27
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (4)
.vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml (1)
352-359: 🧹 Nitpick (assertive)DRY: Extract Renovate token guard into an anchor
This guard block is duplicated across multiple CircleCI configs. Extract it into a YAML anchor to avoid repetition and simplify future updates..vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml (1)
398-405: 🧹 Nitpick (assertive)DRY: Extract Renovate token guard into a shared anchor
Identical guard logic appears in several fixture configs. Centralize this in a YAML anchor for reuse and maintainability..vortex/installer/tests/Fixtures/install/ciprovider_circleci/.circleci/config.yml (1)
398-405: 🧹 Nitpick (assertive)DRY: Extract Renovate token guard into a YAML anchor
The same guard snippet is present in multiple CI configs. Move it into an anchor to adhere to DRY principles and ease future changes..vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml (1)
398-405: 🧹 Nitpick (assertive)Consolidate repeated token-check logic with YAML anchors
This guard is duplicated across multiple CircleCI fixture configs. Consider defining the check block as a reusable YAML anchor at the top of the config and referencing it in eachrunstep to centralize maintenance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Lite
📒 Files selected for processing (8)
.circleci/config.yml(1 hunks).github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/ciprovider_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml(1 hunks)
🔇 Additional comments (5)
.github/workflows/deps-updates.yml (2)
18-27: Appropriate token presence check
The step correctly handles both the missing-token case and sets an output flag for downstream steps. This pattern avoids job-levelsecretscontext issues and cleanly gates the Renovate execution.
28-30: Conditional execution based on token check
Usingif: steps.check-token.outputs.token_exists == 'true'properly gates the Renovate action, ensuring it only runs when the token is present..vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml (1)
29-29: Correct conditional for Renovate step execution
Theif: steps.check-token.outputs.token_exists == 'true'expression ensures the Renovate step only runs when the token exists. This matches best practices for output-based gating in GitHub Actions..vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml (1)
5-6:✅ Verification successful
Update fallback email in
RENOVATE_GIT_AUTHOR
The default author address has been updated torenovatebot@the-new-hope-domain.example. Ensure that this new placeholder domain is correct and that all other workflows or configurations referencing the old domain have been updated accordingly.Run this script to verify remaining occurrences of the old domain:
🏁 Script executed:
#!/bin/bash # Search for any references to the old fallback email across the repo rg -n "star-wars-domain\.example" --glob "*.yml"Length of output: 50
Let’s do a comprehensive scan across all files for the old domain to be sure nothing slipped through:
🏁 Script executed:
#!/bin/bash # Recursively search entire repo for any lingering references to the old fallback domain rg -n "star-wars-domain\.example"Length of output: 35
Approve domain update – no remaining references found
A global search forstar-wars-domain.examplereturned no matches. The fallback email in.vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.ymlhas been correctly updated torenovatebot@the-new-hope-domain.example. No further changes are needed..vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml (1)
398-405: CircleCI guard forRENOVATE_TOKEN
The addedrunstep properly halts the Renovate job early whenRENOVATE_TOKENis unset, preventing unnecessary downstream steps. The use ofcircleci-agent step haltfollowed byexit 0ensures the job succeeds gracefully.
.vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml
Show resolved
Hide resolved
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (6)
.circleci/config.yml (2)
424-431: 🧹 Nitpick (assertive)Consider moving the token check before the
checkoutstep
Placing this guard beforecheckoutavoids cloning the repository when the token is missing, saving build time.
424-431: 🧹 Nitpick (assertive)Extract guard logic into a reusable YAML anchor
This snippet is duplicated across several jobs and fixture configs. Defining it once as an anchor and referencing it will reduce repetition and simplify maintenance..vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml (1)
352-359: 🧹 Nitpick (assertive)Extract guard logic into a reusable YAML anchor
Reducing duplication by defining this check as an anchor will improve maintainability across fixture configs..vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml (1)
398-405: 🧹 Nitpick (assertive)Extract guard logic into a reusable YAML anchor
Consolidating this duplicated snippet into an anchor will adhere to DRY principles and ease future updates..vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml (1)
398-405: 🧹 Nitpick (assertive)Extract guard logic into a reusable YAML anchor
Consider defining this token check as a YAML anchor to avoid repeating it in each fixture config..vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml (1)
18-26: 🧹 Nitpick (assertive)Extract token check into a reusable action (duplicate).
The inline script correctly guards against a missing
RENOVATE_TOKEN, but this pattern is repeated across workflows and fixtures. Consider refactoring it into a composite action or shared workflow to DRY up your CI configurations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Lite
📒 Files selected for processing (8)
.circleci/config.yml(1 hunks).github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/ciprovider_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml(1 hunks)
🔇 Additional comments (8)
.vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml (1)
5-6: Updated fallback email for RENOVATE_GIT_AUTHOR
The new fallback email domainthe-new-hope-domain.examplealigns with the updated naming convention. No other changes are necessary here..circleci/config.yml (1)
424-431: Implement early guard for missing RENOVATE_TOKEN
The new step correctly halts the Renovate job when theRENOVATE_TOKENis unset, preventing subsequent steps from running..vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml (1)
352-359: Implement early guard for missing RENOVATE_TOKEN
The guard correctly skips the Renovate job when the token is not provided..vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml (1)
398-405: Implement early guard for missing RENOVATE_TOKEN
This step ensures the job exits gracefully if the token is absent..vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml (1)
398-405: Implement early guard for missing RENOVATE_TOKEN
The new guard correctly skips the Renovate steps when the environment variable is unset..vortex/installer/tests/Fixtures/install/ciprovider_circleci/.circleci/config.yml (1)
398-405: Approve CircleCI token presence guard.The new
runstep correctly checks for an empty or unsetRENOVATE_TOKEN, halts further steps withcircleci-agent step halt, and exits cleanly. This aligns with the main CI configuration and prevents unnecessary execution when the token is missing..github/workflows/deps-updates.yml (1)
29-30: Approve conditional execution of Renovate.Using
if: steps.check-token.outputs.token_exists == 'true'ensures that the Renovate step only runs when a valid token is present..vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml (1)
29-30: Approve baseline conditional guard.The
if: steps.check-token.outputs.token_exists == 'true'condition properly prevents the Renovate step from running without a token.
| - name: Check Renovate Token | ||
| id: check-token | ||
| run: | | ||
| if [ -z "${{ secrets.RENOVATE_TOKEN }}" ]; then | ||
| echo "Renovate token is not set. Skipping Renovate step." | ||
| exit 0 | ||
| else | ||
| echo "token_exists=true" >> "$GITHUB_OUTPUT" | ||
| fi |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Approve GitHub Actions token check step.
This step properly skips the Renovate action when secrets.RENOVATE_TOKEN is unset or empty, and emits a token_exists output for downstream gating. To reduce duplication across multiple workflows, consider encapsulating this logic in a composite GitHub Action or reusable workflow.
🤖 Prompt for AI Agents
In .github/workflows/deps-updates.yml around lines 18 to 26, the Renovate token
check step works correctly but duplicates logic across workflows. Refactor by
extracting this token check logic into a composite GitHub Action or a reusable
workflow file. Then update this workflow to call that reusable component,
reducing duplication and improving maintainability.
There was a problem hiding this comment.
@coderabbitai could this have used an ‘if:’ check on the step?
There was a problem hiding this comment.
@AlexSkrypnyk Yes, this could definitely have used a direct 'if:' condition on the step instead of a separate check. It could be simplified to:
- name: Self-hosted Renovate
if: secrets.RENOVATE_TOKEN != ''
uses: renovatebot/github-action@v42.0.2
# rest of the step configuration...The current approach with a separate check step does provide explicit logging when the token is missing, which might be helpful for troubleshooting, but the direct 'if:' condition would be more concise.
🐰 thinking
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
skipper-vp
added
the
Needs review
AlexSkrypnyk
left a comment
AlexSkrypnyk
left a comment
There was a problem hiding this comment.
@skipper-vp
please see my comments
| - name: Check Renovate Token | ||
| id: check-token | ||
| run: | | ||
| if [ -z "${{ secrets.RENOVATE_TOKEN }}" ]; then | ||
| echo "Renovate token is not set. Skipping Renovate step." | ||
| exit 0 | ||
| else | ||
| echo "token_exists=true" >> "$GITHUB_OUTPUT" | ||
| fi |
.circleci/config.yml
Outdated
| if [ -z "${RENOVATE_TOKEN}" ]; then | ||
| echo "RENOVATE_TOKEN is not set. Skipping Renovate job." | ||
| circleci-agent step halt | ||
| exit 0 |
AlexSkrypnyk
added
Requires more work
|
@skipper-vp |
.github/workflows/deps-updates.yml
Outdated
| run: | | ||
| if [ -z "${{ secrets.RENOVATE_TOKEN }}" ]; then | ||
| echo "Renovate token is not set. Skipping Renovate step." | ||
| exit 0 |
There was a problem hiding this comment.
this is not needed exit 0
AlexSkrypnyk
changed the title
skipper-vp
force-pushed
the
feature/1618-renovate-token-check
branch
from
cd6eb27 to
648df5b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (6)
.circleci/config.yml (1)
424-431: 🧹 Nitpick (assertive)Consolidate and reposition RENOVATE_TOKEN guard
The check forRENOVATE_TOKENis correctly preventing Renovate steps from running when the token is absent. However, this guard is duplicated across multiple jobs and still sits aftercheckout, causing an unnecessary repo clone when the token is missing. Consider extracting this logic into a reusable YAML anchor to DRY up the config, and moving it before thecheckoutstep to avoid cloning altogether..vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml (1)
352-359: 🧹 Nitpick (assertive)Extract RENOVATE_TOKEN guard into an anchor
This early-exit snippet is duplicated across several fixture configs. To improve maintainability, extract theif [ -z "${RENOVATE_TOKEN}" ] … fiblock into a shared YAML anchor (or include a script) and reference it in eachdeps-updatesjob..vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml (1)
398-405: DRY principle: Consolidate Renovate token check
TheCheck if RENOVATE_TOKEN is setstep correctly halts the job when the token is missing. Since this logic is duplicated across multiple CircleCI fixture configs, consider extracting it into a shared YAML anchor (e.g.,&renovate_token_check) and referencing it in each job to centralize maintenance..vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml (1)
398-405: DRY principle: Consolidate Renovate token check
The guard step properly exits the Renovate job whenRENOVATE_TOKENis unset. To reduce repetition across fixture configs, extract this snippet into a YAML anchor (e.g.,&renovate_token_check) and reuse it in eachdeps-updatesjob..github/workflows/deps-updates.yml (1)
18-27: DRY & Simplification: Token check step
The "Check Renovate Token" step effectively skips the Renovate action when the secret is missing. To avoid duplicating this logic across workflows, consider extracting it into a composite GitHub Action or reusable workflow. Alternatively, you could simplify by addingif: secrets.RENOVATE_TOKEN != ''directly on the "Self-hosted Renovate" step and removing the separate guard step..vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml (1)
18-26: DRY principle: Reusable token check
This pre-check correctly skips Renovate whenRENOVATE_TOKENis absent. To DRY up across multiple workflows, refactor the logic into a composite Action or reusable workflow step, then invoke it here and in other workflows for consistency and easier maintenance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Lite
📒 Files selected for processing (9)
.circleci/config.yml(1 hunks).github/workflows/deps-updates.yml(1 hunks).vortex/docs/content/tools/renovate.mdx(1 hunks).vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/ciprovider_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml(1 hunks)
🔇 Additional comments (2)
.vortex/docs/content/tools/renovate.mdx (1)
34-35: Good clarification on graceful skip
The added note accurately reflects the CI behavior: ifRENOVATE_TOKENis absent, the job is skipped without failure. This aligns the documentation with the updated workflows..vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml (1)
5-6:✅ Verification successful
Rename fallback author email
The defaultRENOVATE_GIT_AUTHORaddress has been updated torenovatebot@the-new-hope-domain.example. Please ensure this change is mirrored in any other workflows or docs using the oldstar-wars-domain.exampleaddress.Run this script to locate any remaining instances of the old email:
🏁 Script executed:
#!/bin/bash # Find leftover occurrences of the old fallback author email rg -l 'renovatebot@star-wars-domain\.example'Length of output: 47
All occurrences of the old fallback author email have been replaced
Ranrg -l 'renovatebot@star-wars-domain\.example'with no matches. No further action required.
| - run: | ||
| name: Check if RENOVATE_TOKEN is set | ||
| command: | | ||
| if [ -z "${RENOVATE_TOKEN}" ]; then | ||
| echo "RENOVATE_TOKEN is not set. Skipping Renovate job." | ||
| circleci-agent step halt | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Centralize Renovate token check
The pre-check for RENOVATE_TOKEN repeats here as well. For consistency and easier future updates, factor this guard into a YAML anchor or common snippet, and consider running it before checkout to skip cloning when the token is unset.
🤖 Prompt for AI Agents
In
.vortex/installer/tests/Fixtures/install/ciprovider_circleci/.circleci/config.yml
around lines 398 to 405, the check for RENOVATE_TOKEN is duplicated. Refactor
this by creating a YAML anchor or reusable snippet for the RENOVATE_TOKEN guard
and reference it where needed. Move this check to run before the checkout step
to avoid unnecessary cloning when the token is not set, improving efficiency and
maintainability.
648df5b to
629767e
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (5)
.vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml (1)
18-26: Extract token check into reusable component
The inline token presence check is duplicated across multiple workflows. Consider refactoring this logic into a composite GitHub Action or reusable workflow to DRY up and maintain consistency across alldeps-updatesworkflows..vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml (1)
352-359: DRY up Renovate token guard across CircleCI fixtures
Therun: Check if RENOVATE_TOKEN is setstep is duplicated in multiple fixture configs. Extract this pre-check into a reusable YAML anchor (or single command definition) and reference it in eachdeps-updatesjob to adhere to DRY principles and simplify future updates..vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml (1)
398-405: Consolidate Renovate token check into a shared anchor
The early exit guard forRENOVATE_TOKENrepeats here as well. Define this step in one place (e.g., a YAML anchor underaliases:) and reference it in eachdeps-updatesjob to avoid duplication and ease maintenance..vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml (1)
398-405: Centralize the Renovate token guard for maintainability
ThisCheck if RENOVATE_TOKEN is setrun step is identical to other fixtures. Consider moving the logic into a single YAML anchor or reusable command and then referencing it here, so updates to the guard only need to be made in one location..vortex/installer/tests/Fixtures/install/ciprovider_circleci/.circleci/config.yml (1)
398-405: 🧹 Nitpick (assertive)Optimize and DRY the Renovate token guard
- To avoid cloning the repo when the token is missing, move this
Check if RENOVATE_TOKEN is setstep to run before thecheckoutstep.- This guard is duplicated across fixtures—extract it into a YAML anchor under
aliases:(or a common command) and reference it in eachdeps-updatesjob for easier maintenance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Lite
📒 Files selected for processing (9)
.circleci/config.yml(1 hunks).github/workflows/deps-updates.yml(1 hunks).vortex/docs/content/tools/renovate.mdx(1 hunks).vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/ciprovider_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/.circleci/config.yml(1 hunks).vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml(1 hunks)
🔇 Additional comments (4)
.circleci/config.yml (1)
424-431: Early exit guard is correct
The newly addedCheck if RENOVATE_TOKEN is setstep properly halts the Renovate job when the token is missing, preventing downstream steps from running without authentication and avoiding failures..github/workflows/deps-updates.yml (1)
18-26: Check step correctly skips Renovate
TheCheck Renovate Tokenstep ensures that the workflow outputs a friendly message and exits successfully whenRENOVATE_TOKENis not set, preventing any further Renovate actions without causing failures..vortex/docs/content/tools/renovate.mdx (1)
34-35: Clarify missing token behavior in documentation
This note accurately reflects the CI/CD updates by stating that the Renovate job will still run but skip update steps whenRENOVATE_TOKENis not provided, preventing build failures and matching the implemented behavior..vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml (1)
5-6: Update default Git author email
The fallbackRENOVATE_GIT_AUTHORemail has been updated torenovatebot@the-new-hope-domain.example. Ensure this new domain is correct for commit attribution in self-hosted workflows.
| if: steps.check-token.outputs.token_exists == 'true' | ||
| uses: renovatebot/github-action@v42.0.2 |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Consolidate conditional into step-level if
You can eliminate the separate check step and instead use a single if: secrets.RENOVATE_TOKEN != '' on the uses: renovatebot/github-action step. This reduces verbosity while still safely skipping the action when the token is absent.
🤖 Prompt for AI Agents
In .github/workflows/deps-updates.yml at lines 29 to 30, the current workflow
uses a separate step to check if the token exists before running the renovatebot
action. Remove the separate token check step and instead add an `if:
secrets.RENOVATE_TOKEN != ''` condition directly on the
renovatebot/github-action step to simplify the workflow and skip the action
safely when the token is missing.
d7babee to
cc12e15
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Lite
📒 Files selected for processing (3)
.github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml(1 hunks)
🔇 Additional comments (1)
.vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml (1)
5-6: Approve update to the default Renovate Git author email in the names fixture
Changing the placeholder fromstar-wars-domain.exampletothe-new-hope-domain.examplealigns with the new naming convention in this test fixture without impacting production workflows.
| - name: Check Renovate Token | ||
| id: check-token | ||
| run: | | ||
| if [ -z "${{ secrets.RENOVATE_TOKEN }}" ]; then | ||
| echo "Renovate token is not set. Skipping Renovate step." | ||
| else | ||
| echo "token_exists=true" >> "$GITHUB_OUTPUT" | ||
| fi | ||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Extract baseline token-check into a reusable component
The baseline fixture correctly implements the token-presence check and output quoting. To keep your test fixtures in sync and reduce duplication, consider moving this script into a shared composite action or workflow and invoking it here:
- - name: Check Renovate Token
- id: check-token
- run: |
- if [ -z "${{ secrets.RENOVATE_TOKEN }}" ]; then
- echo "Renovate token is not set. Skipping Renovate step."
- else
- echo "token_exists=true" >> "$GITHUB_OUTPUT"
- fi
+ - uses: ./.github/actions/check-renovate-token@v1Also applies to: 28-29
🤖 Prompt for AI Agents
In
.vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml
around lines 18 to 26 and also lines 28-29, the Renovate token check script is
duplicated. Refactor by extracting this token-presence check into a reusable
composite action or workflow. Then replace the inline script here with a call to
that shared component to reduce duplication and keep test fixtures consistent.
|
@AlexSkrypnyk Redundant |
AlexSkrypnyk
changed the title
RENOVATE_TOKEN set.
…#1646) Co-authored-by: Andrey Simonov <andrey.simonov@morpht.com> Co-authored-by: Alex Skrypnyk <alex@drevops.com>
[#1618]: Added renovate token check.
Summary by CodeRabbit