Repository navigation
ledger: record the merge commits of requirements that landed - #415
Merged
Merged
Conversation
zendev-machine
Bot
added
area:spec
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class: machine-generated, produced by
release-tag.yml. No linkedIssue by construction, no agent reviews it, accepted mechanically under
docs/zendev/MACHINE_PULL_REQUESTS.md.MERGE_COMMITnames the commit that satisfied a requirement, and the runthat earns the row cannot know it: the row lands inside a pull request and
the squash commit does not exist until that pull request merges. This fills
that column and nothing else — no
STATUSis touched, because whether arequirement is satisfied is a judgement and this is a lookup.
It matters because
release_tag.pyhashes(REQ_ID, MERGE_COMMIT)pairs todecide whether a milestone has been released at these commits or different
ones. With blanks in it, a milestone repaired at new commits hashes
identically to the one released before, and the patch release that exists
for exactly that case is never cut.