Skip to content

Formally close the M0 baseline-lock gate (REQ-MIGRATION-001) - #24

Merged
drevendev merged 1 commit into
masterfrom
claude/issue-23-req-migration-001
Sep 3, 2026
Merged

drevendev merged 1 commit into
masterfrom
claude/issue-23-req-migration-001

Conversation

@drevendev

Copy link
Copy Markdown
Owner

Closes #23

Achieved outcome

docs/spec/IMPLEMENTATION_STATUS.md now carries a REQ-MIGRATION-001 row naming
the build/test evidence for Gate M0 ("dotnet build succeeds and all existing tests
pass unchanged"), so that gate is a recorded fact tied to a table row instead of an
inspected-but-unrecorded property of master. The row is IN_PROGRESS with Merged in = pending (see Decision comment on #23 for why, and how it resolves).

Tested revision

f06014a on branch claude/issue-23-req-migration-001, based on master @
10af216915bd96f680ec6da4197f408175c96509 (this PR is doc-only — no code changed
relative to that revision).

Changed artifacts

Acceptance criteria

Copied from Issue #23:

  • [~] docs/spec/IMPLEMENTATION_STATUS.md has a REQ-MIGRATION-001 row with
    STATUS=IMPLEMENTED, this Issue's number, the merge commit, and a named proving
    test/evidence. — Row added, but with STATUS=IN_PROGRESS and Merged in = pending
    instead of IMPLEMENTED + merge commit, since this pull request has not merged yet
    and its merge commit does not exist. Follows the precedent PR Add hash-verified seeded legacy baseline (REQ-MIGRATION-002) #18 set for
    REQ-MIGRATION-002 (IN_PROGRESS → IMPLEMENTED via a later reconciliation run,
    AUTHOR_RUNBOOK.md section 1). Named proving evidence and Issue number are present.
  • The summary line in docs/spec/IMPLEMENTATION_STATUS.md is updated to match.
  • dotnet build --configuration Release succeeds with 0 errors.
  • dotnet test --configuration Release --no-build passes with 0 failed (44).
  • No legacy economic behavior, CLI flags, or existing test assertions changed.

Checks

Check Outcome Evidence
dotnet build --configuration Release passed 0 warnings, 0 errors
dotnet test --configuration Release --no-build passed 44/44 passed, 0 failed, 0 skipped
npm run typecheck passed clean
npm test passed 2/2 passed
npm run build passed dist/canonical.js built
python -m unittest discover -s scripts/tests passed 20/20 passed (policy-guard self-tests)

All checks ran locally against tested revision f06014a (based on
10af216915bd96f680ec6da4197f408175c96509) in this run; CI will re-run all three
required jobs (build-and-test, typescript, policy-guard) on the pull request
itself.

Not checked

Nothing deliberately skipped. This is a documentation-only change to one table row
and its summary line; every check the repository defines was run.

Assumptions and unknowns

Highest-risk area for review

The status-naming deviation from the Issue's literal Scope (IN_PROGRESS+pending
instead of IMPLEMENTED+merge commit) is the one judgment call in this PR worth a
second look — reviewer should confirm the PR #18/#21 precedent is the right one to
follow here, or override if they'd rather change the runbook's reconciliation
mechanism instead.

Remaining gate

None known. Once this merges, a later AUTHOR run's section-1 reconciliation step
will flip the REQ-MIGRATION-001 row to IMPLEMENTED with this PR's number and
merge commit, per AUTHOR_RUNBOOK.md.

Record a REQ-MIGRATION-001 row in IMPLEMENTATION_STATUS.md naming this
Issue's build/test evidence, matching Gate M0's "build succeeds and all
existing tests pass unchanged." Follows the same in-progress-until-merged
pattern PR #18 used for REQ-MIGRATION-002; a later reconciliation run
flips it to IMPLEMENTED once this merges.

Closes #23

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@drevendev

Copy link
Copy Markdown
Owner Author

ACCEPT

  1. Every required check measured green at head f06014a1fa861745a0f7b1e303f6875d213fcaf4: build-and-test, typescript, policy-guard all SUCCESS per gh pr checks 24.
  2. All five acceptance criteria from Issue Formally close the M0 baseline-lock gate (REQ-MIGRATION-001) #23 are met:
    • Row added for REQ-MIGRATION-001 with named proving evidence (build + full 44-test suite at 10af216915bd96f680ec6da4197f408175c96509). Status is IN_PROGRESS/Merged in = pending rather than IMPLEMENTED+merge-commit, per the Decision comment on Formally close the M0 baseline-lock gate (REQ-MIGRATION-001) #23 — this correctly follows the reconciliation pattern formalized in AUTHOR_RUNBOOK.md section 1 (added by PR Reconcile IMPLEMENTATION_STATUS.md and add the runbook step that keeps it honest #21 for the identical REQ-MIGRATION-002 situation): a PR cannot cite its own not-yet-existent merge commit, so it lands IN_PROGRESS and a later run's reconciliation step flips it. This is the only available non-self-contradictory choice, not a shortcut.
    • Summary line updated to "1 of 19 ... 1 in progress" — confirmed in diff.
    • dotnet build --configuration Release --no-restore: reran myself on the PR head in an isolated worktree — 0 warnings, 0 errors.
    • dotnet test --configuration Release --no-build: reran myself — 44/44 passed, 0 failed, 0 skipped.
    • No legacy economic behavior, CLI flags, or test assertions touched — diff is exactly one file, docs/spec/IMPLEMENTATION_STATUS.md, 5 insertions/4 deletions, doc-only.
  3. Diff confined to declared scope (Issue Formally close the M0 baseline-lock gate (REQ-MIGRATION-001) #23 Scope explicitly names this file); no .github/workflows/**, AGENTS.md, or docs/zendev/** touched.
  4. No invariant or test weakened — no test file in the diff.
  5. No secret, credential, or personal data present — diff is a table row and a summary sentence.
  6. Handoff record in the PR body is complete (outcome, tested revision, changed artifacts, acceptance criteria with status, checks table, not-checked, assumptions/unknowns, highest-risk area, remaining gate).

Additionally reran npm run typecheck, npm test (2/2), npm run build, and python -m unittest discover -s scripts/tests (20/20) plus python scripts/policy_guard.py --base master (passed) myself on the PR head — all match the PR's claimed evidence.

Merging.

@drevendev
drevendev merged commit 7d732d1 into master Sep 3, 2026
3 checks passed
@drevendev
drevendev deleted the claude/issue-23-req-migration-001 branch September 3, 2026 20:53
drevendev added a commit that referenced this pull request Sep 3, 2026
Issue #23 (closed by PR #24) merged with the REQ-MIGRATION-001 row
deliberately left IN_PROGRESS/pending, per the section-1 reconciliation
mechanism established by Issue #19 / PR #21. That mechanism is exercised
here: flip the row to IMPLEMENTED, name PR #24 and its merge commit, and
correct the summary line.

Refs #25

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
drevendev added a commit that referenced this pull request Sep 10, 2026
…ew it (#399)

load_merged_pulls read the newest 200 merged pull requests. The repository passed two
hundred merges today; #24, merged on 2026-09-03, fell out of the window between the
check on #397 and the check on its merge, and rule 2 refused the push to master for a
row that was correct. From that moment every push and pull request was refused.

The limit is now 2000, and any pull request the ledger cites that the listing still
does not carry is asked about individually before rule 2 may call it unmerged.

Closes #398

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formally close the M0 baseline-lock gate (REQ-MIGRATION-001)

1 participant