Skip to content

master does not compile: #208 merged against a base it no longer fitted #274

Closed

Description

@drevendev

Goal

Get master compiling again. It has been red since 2026-09-07T22:55:19Z and every open
pull request inherits the failure, so nothing can merge.

Evidence

src/simulation/worldState.ts(542,9): error TS2741: Property 'pendingTransitions' is
  missing in type '{ ... }' but required in type 'WorldState'.
src/simulation/genesisReconciliation.test.ts(34,7): error TS2353: Object literal may
  only specify known properties, and 'minimumPrice' does not exist in type 'MarketConfig'.

Both arrived with the merge of #208 at 22:55:17Z. That branch was opened 2026-09-06
09:49 and its checks were green against the base it was written on. Between then and the
merge, master gained WorldState.pendingTransitions (#247, REQ-CORE-005) and reshaped
MarketConfig (#250, REQ-MARKET-002). Branch protection runs with
strict: false — "require branches to be up to date before merging" is off — so a
36-hour-old branch whose own checks were green merged into a base it no longer fitted.

minimumPrice and maximumPrice are real, but they belong to the pricing config in
src/simulation/marketPricing.ts, not to MarketConfig in src/config/simulationConfig.ts.
The test literal put them in the wrong one; nothing reads them there.

Scope

  • src/simulation/worldState.ts
  • src/simulation/genesisReconciliation.test.ts

Non-goals

Changing what reconciliation does, or touching MarketConfig itself. This restores the
build and nothing else.

Acceptance criteria

  1. npm run typecheck is clean.
  2. npm test passes with no test removed or weakened.
  3. tempWorldState carries an empty PendingTransitions, the same value the real
    WorldState is built with a few lines below.

Verification

npm run typecheck and npm test on the branch.

Activity

  1. added
    priority:criticalImmediate action: correctness, data-loss, or release-blocking risk
    type:bugVerified behavior differs from the intended contract
    area:simulation-coreTick loop, ordering, determinism, configuration
    status:in-progressClaimed work with an active branch or pull request
    on Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:simulation-coreTick loop, ordering, determinism, configurationpriority:criticalImmediate action: correctness, data-loss, or release-blocking risktype:bugVerified behavior differs from the intended contract

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions