Upgrade HBase community connector for Dremio 4.7.3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tifflhl
commented
Aug 27, 2020
•
tifflhl
commented
- Updated README.md to reference Dremio release 4.7.3-202008270723550726-918276ee.
- Updated converters to use org.apache.arrow.memory.ArrowBuf.
keeratsingh
approved these changes
Aug 28, 2020
tifflhl
changed the title
jacques-n
reviewed
Sep 2, 2020
pom.xml
Outdated
| <artifactId>dremio-hbase-plugin</artifactId> | ||
|
|
||
| <name>Dremio HBase Community Connector</name> | ||
|
|
||
| <properties> | ||
| <hbase.TestSuite>**/HBaseTestsSuite.class</hbase.TestSuite> | ||
| <version.dremio>4.2.2-202004211133290458-b550b6fa</version.dremio> | ||
| <version.dremio>4.7.3-202008270723550726-918276ee</version.dremio> |
There was a problem hiding this comment.
let's move this to ${project.version} as opposed to duplicating.
README.md
Outdated
| @@ -7,9 +7,9 @@ | |||
| To add the Dremio Community HBase Connector to the list of Dremio sources: | |||
|
|
|||
| 1. From the project root, run `mvn clean install`. | |||
| The HBase Connector `dremio-hbase-plugin-4.2.2-202004211133290458-b550b6fa.jar` appears in the `target` directory. | |||
| The HBase Connector `dremio-hbase-plugin-4.7.3-202008270723550726-918276ee.jar` appears in the `target` directory. | |||
There was a problem hiding this comment.
I suggest that we replace with a token such as so we don't have to update each time we upgrade.
There was a problem hiding this comment.
I read through a couple Github markdown guides, I didn't find a way to make static text variables. Can you elaborate what you meant be tokenizing the version number?
There was a problem hiding this comment.
I just meant put placeholder text and let the user figure out the number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.