Add events to calendar - Solves #1 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHenever the user sets a date in the future, she or he will be given the opportunity to create a calendar event based on the chosen date. This is going to be expended upon but this first iteration introduces this possibility to the 'discover moment' dialog. By setting a value to any of the inpur fields, a 'Add to calendar' link will appear. The link and the options that show after clicking on it aren't styled at this point, but will be.
This also solves the collateral problem of using 'nowDate' for calculation: elements wrapped by the condition get re-rendered, breaking accessibility as the element looses focus. With this fix we get the time at the time of first render, which is called 'nowDailyDate' in the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.