Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch posts with a specific post type #34

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Fetch posts with a specific post type #34

merged 2 commits into from
Apr 24, 2020

Conversation

Cobolt77
Copy link
Contributor

/wp-json/wp/v2/posts/ becomes /wp-json/wp/v2/<post_type>/

@Cobolt77
Fetch post with a specific post type
de2ff43 
/wp-json/wp/v2/posts/ becomes /wp-json/wp/v2/<post_type>/
@Cobolt77 Cobolt77 changed the title Fetch post with a specific post type Fetch posts with a specific post type Apr 23, 2020
@Cobolt77 Cobolt77 closed this Apr 23, 2020
@Cobolt77 Cobolt77 reopened this Apr 23, 2020
This was referenced Apr 23, 2020
Closed
Open
SachinGanesh
SachinGanesh reviewed Apr 24, 2020
View reviewed changes
Copy link
Collaborator

@SachinGanesh SachinGanesh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let the default type be "posts" instead of null. You can use the same URL instead of null check. It will be easy for others to use the API

@Cobolt77
Copy link
Contributor Author

Sorry! Haven't thought of that! It's my first time contributing to someone else's code!

@SachinGanesh SachinGanesh merged commit 83260f0 into dreamsoftin:master Apr 24, 2020
@SachinGanesh
Copy link
Collaborator

Thank you for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SachinGanesh SachinGanesh SachinGanesh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cobolt77 @SachinGanesh